Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using deprecated config access #19

Open
chrisbitmead opened this issue Nov 29, 2022 · 2 comments
Open

using deprecated config access #19

chrisbitmead opened this issue Nov 29, 2022 · 2 comments

Comments

@chrisbitmead
Copy link

on ShiroGrailsPlugin.groovy line 199 it accesses configuration using the deprecated direct access

grailsApplication.config.info.app.name

instead of:

grailsApplication.config.getProperty('info.app.name')

I think it was very dumb for grails to deprecate this, but it is what it is.

@pmcneil
Copy link
Member

pmcneil commented Nov 29, 2022

This method has some checks for existence and the ability to provide a default I believe, so it's a good thing. Reminds me I need to update this plugin and release it !

@chrisbitmead
Copy link
Author

The groovy language also has syntax to check for existence and provide a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants