Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamux: can not work properly when server listening on a serial port inside VM, and client connet the serial port socket outside VM #314

Open
abel-von opened this issue Mar 25, 2021 · 2 comments
Labels
s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

Comments

@abel-von
Copy link

package sent by server can not reach client.

@abel-von abel-von changed the title can not work properly when server listening on a serial port inside VM, and client connet the serial port socket outside VM yamux: can not work properly when server listening on a serial port inside VM, and client connet the serial port socket outside VM Mar 25, 2021
@driftluo
Copy link
Collaborator

I'm not sure what serial port you are talking about, but yamux itself is just a subcontracting library. The real communication depends on the underlying io implementation. If the underlying io abstraction does not correctly implement the two traits of AsyncRead and AsyncWrite, it will not be possible to work.

You can see that when I was testing, I mocked a memory io, If there is a problem, such a test will also be problematic.

I suggest whether to provide a mock scene reproduction to facilitate the location of the problem

@driftluo driftluo added the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Apr 14, 2021
@driftluo
Copy link
Collaborator

maybe fix by #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

No branches or pull requests

2 participants