Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overriding the visibility of the generated accessors #15

Open
nesk opened this issue Oct 7, 2023 · 1 comment
Open

Support overriding the visibility of the generated accessors #15

nesk opened this issue Oct 7, 2023 · 1 comment
Labels
enhancement New feature or request ksp-plugin The KSP plugin is involved

Comments

@nesk
Copy link
Owner

nesk commented Oct 7, 2023 •
edited
Loading

  • we sould ignore all private/protected properties
  • we should generate accessors for internal/public properties
  • a property can be public in a private class, we should be careful with this
  • the accessor should have the same visibility than the property
  • the user should be able to override the visibility of the whole accessors, to force them being internal for example, to avoid leaks into the public API
@nesk nesk converted this from a draft issue Oct 7, 2023
@nesk nesk added enhancement New feature or request ksp-plugin The KSP plugin is involved labels Oct 7, 2023
nesk added a commit that referenced this issue Oct 7, 2023
@nesk
ksp-plugin: generate accessors only for public properties (#11 #15)
1c2f0dd
nesk added a commit that referenced this issue Oct 7, 2023
@nesk
ksp-plugin: generate accessors only for public properties (#11 #15)
77c25da
nesk added a commit that referenced this issue Oct 9, 2023
@nesk
ksp-plugin: generate accessors only for public properties (#11 #15)
92119a3
nesk added a commit that referenced this issue Oct 9, 2023
@nesk
ksp-plugin: generate accessors only for public properties (#11 #15)
9137ecc
@nesk
Copy link
Owner Author

nesk commented Sep 29, 2024

This might not be a priority anymore. Maybe we should focus on providing a K2 plugin compiler, like Kopy does. It would be way more versatile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ksp-plugin The KSP plugin is involved
Projects
Akkurate's public roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nesk