Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate vuex to store and handle state. #234

Open
Keimeno opened this issue Jul 22, 2020 · 3 comments
Open

Integrate vuex to store and handle state. #234

Keimeno opened this issue Jul 22, 2020 · 3 comments

Comments

@Keimeno
Copy link
Contributor

Keimeno commented Jul 22, 2020

Is your feature request related to a problem? If so, please describe.
The problem currently is, if we route to /gallery it sends a requests to receive information about 24 packages. However if we go to any other route and come back to /gallery later, it refetches those 24 packages.

Describe the solution you'd like
This could be avoided by using vuex to persist the data until we reload. It will also make the code cleaner, as the api action is abstracted from the vue component.
@zorbyte zorbyte changed the title feat: integrate vuex to store and handle state. Integrate vuex to store and handle state. Jul 22, 2020
@littledivy
Copy link
Member

I think vuex will be great! We could also add i18n support with it.

@t8
Copy link
Member

t8 commented Jul 23, 2020

Was just about to say that myself! I totally agree. This would be very useful, while also reducing the load on the API.

@Keimeno
Copy link
Contributor Author

Keimeno commented Jul 23, 2020

Would be interested in adding it myself. However it would make sense to do so after the Typescript migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@t8 @maximousblk @littledivy @zorbyte @Keimeno