Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit the liberal use of open #63

Open
nap-sam-dean opened this issue Apr 4, 2017 · 0 comments
Open

Audit the liberal use of open #63

nap-sam-dean opened this issue Apr 4, 2017 · 0 comments
Labels
good first task

Comments

@nap-sam-dean
Copy link
Member

We're marking lots of things as open when I don't think they need/should be i.e. the step(_:file:line:function:) methods in StepDefiner. They should be public, but I don't see why they need to be overridable.

I think the Xcode auto migrate tool has been a bit liberal, and I should probably have checked more closely!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kerrmarin @nap-sam-dean