Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method replyTo should accept null as parameter #187

Open
jfradj opened this issue Apr 6, 2024 · 1 comment
Open

Method replyTo should accept null as parameter #187

jfradj opened this issue Apr 6, 2024 · 1 comment
Labels

Comments

@jfradj
Copy link
Contributor

jfradj commented Apr 6, 2024

Hello,

I think that the the method prototype isn't totally correct:

public function replyTo(string $message_id): self

Indeed, it should allow to set the value to null, so the prototype should be:

public function replyTo(?string $message_id): self

(note the question mark to all null to be passed as an argument).
Right now, I used the empty string as a workaround, but it's a little bit ugly 🥲

I've audited the code, and everything has been designed to make that possible.

@aalbarca
Copy link
Contributor

Hi @jfradj could you please open a PR with the change? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants