Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages router middleware should return 302 status for redirected data requests #2467

Open
serhalp opened this issue Jun 13, 2024 · 0 comments
Labels
Next.js e2e test failure Errors identified through the Next.js repo e2e tests Next.js

Comments

@serhalp
Copy link
Contributor

serhalp commented Jun 13, 2024

When redirecting a data request, middleware returns a response with x-nextjs-redirect, rather than a location header. We handle this correctly. However Next.js expects us to directly return and empty response with a 302 response code (without the location header), whereas we're currently passing the request on to the origin and returning the body with 404 code. I'm unsure if it's legal to return a 302 with no location, but it's what next start does, and the router expects.

Data

The following is parsed automatically by the Next.js repo e2e test report generator.

test case: https://github.com/vercel/next.js/blob/canary/test/e2e/middleware-redirects/test/index.test.ts#L100
test: test/e2e/middleware-redirects/test/index.test.ts
reason: Pages router middleware should return 302 status for redirected data requests

@serhalp serhalp added type: bug code to address defects in shipped code Next.js e2e test failure Errors identified through the Next.js repo e2e tests labels Jun 13, 2024
@serhalp serhalp added the Next.js label Jun 14, 2024 — with Linear
@serhalp serhalp removed the type: bug code to address defects in shipped code label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next.js e2e test failure Errors identified through the Next.js repo e2e tests Next.js
Projects
None yet
Development

No branches or pull requests

1 participant