Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins with required inputs #57

Open
erezrokah opened this issue May 27, 2020 · 7 comments
Open

Remove plugins with required inputs #57

erezrokah opened this issue May 27, 2020 · 7 comments

Comments

@erezrokah
Copy link
Contributor

erezrokah commented May 27, 2020

Some plugins fail UI installation since the have required inputs:

 - netlify-plugin-brand-guardian
 - netlify-plugin-rss
 - netlify-plugin-add-instagram

We should remove them as they fail the build immediately when installed from UI.

This is only a partial list

@erezrokah
Copy link
Contributor Author

erezrokah commented May 27, 2020

Fixed via #58

@erezrokah
Copy link
Contributor Author

Re-opening, we should also remove:

@erezrokah erezrokah reopened this May 28, 2020
@ehmicky
Copy link
Contributor

ehmicky commented May 28, 2020

Should we send PRs to those plugins to add default values to those plugins?
Or post an issue asking the plugin author to add those?

@erezrokah
Copy link
Contributor Author

I would say - if it's a small PR we can do it ourselves.
Not sure how a default value would look like for the ghost plugin

@erezrokah
Copy link
Contributor Author

Also related https://github.com/getsentry/sentry-netlify-build-plugin, we just need to open a PR for them to remove the required inputs as they already fallback to env variables.

@verythorough
Copy link
Contributor

@erezrokah Does the Ghost plugin not work when the required env vars are set?

@erezrokah
Copy link
Contributor Author

erezrokah commented Jun 2, 2020

The Ghost plugin has required inputs so it fails validation in Netlify build when installed from UI.
Even if they change the inputs to not required, they currently don't have fallback code like the sentry plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants