Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerBuildCmd should execute docker commands to build docker image #6

Open
DineshAlapati opened this issue Jan 23, 2018 · 3 comments

Comments

@DineshAlapati
Copy link

DockerBuildCmd utility class relies on build.sh script to build docker image. As light-codegen does not generate this file, we should execute docker commands instead of executing build.sh script.

@stevehu
Copy link
Contributor

stevehu commented Jan 24, 2018

@DineshAlapati good catch. Is it possible to have a generic build.sh? If yes, we can put it into light-codegen. It is much easy to use build.sh instead docker command line. Thanks

@DineshAlapati
Copy link
Author

Yes we can have a generic build.sh that can be generated from light-codegen but, build.sh requires image name to publish to docker hub. User has to include this image name before running it for first time or we can let the script to take this value as a argument.

@stevehu
Copy link
Contributor

stevehu commented Jan 29, 2018

The image name should be in sync with service name defined in the config.json file. The only variable would be the organization of docker hub. I will try something tonight and we can have a chat tomorrow. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants