Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when test case fails, the server light-bot is not stopped #62

Open
stevehu opened this issue Mar 2, 2019 · 1 comment
Open

when test case fails, the server light-bot is not stopped #62

stevehu opened this issue Mar 2, 2019 · 1 comment

Comments

@stevehu
Copy link
Contributor

stevehu commented Mar 2, 2019

I have added a new test to ensure that dynamic port works with two instances of petstore services. With release 1.5.30, it should fail as we have a bug in the release. The light-bot reports the error but doesn't stop the process. Here is the stacktrace.

21:37:44.772 [main]   INFO  c.n.bot.develop.DevelopBuildTask test - start testing...
21:37:45.772 [main]   INFO  c.n.bot.develop.DevelopBuildTask test - host = https://localhost:2400, path=/v1/pets/111, method=get, request header=null, request body=null
21:37:45.772 [main]   INFO  c.n.bot.develop.DevelopBuildTask test - expected status = 200 response header = {content-type=application/json} response body = {$.name=Jessica Right, $.id=1}
21:37:45.775 [main]   ERROR com.networknt.bot.core.TestUtil request - request Exception:  host = https://localhost:2400 path = /v1/pets/111 method = GET header = null
java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at org.xnio.nio.WorkerThread$ConnectHandle.handleReady(WorkerThread.java:321)
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:561)
21:37:45.775 [main]   INFO  c.n.bot.develop.DevelopBuildTask test - shutdown servers
21:37:45.775 [main]   ERROR c.n.bot.develop.DevelopBuildTask execute - Task could not be executed and failed with: null
21:37:45.775 [main]   INFO  c.n.bot.develop.DevelopBuildTask stop - shutdown servers
21:37:45.775 [main]   INFO  com.networknt.bot.cli.Cli run - build successfully!

@ddobrin
Copy link
Contributor

ddobrin commented Mar 17, 2019

@stevehu - My client has noticed also that the execution of the light-bot is stopping, however the messaging indicates that the process has completed successfully.

Dependent microservices are properly stopped.

It is an older issue which we must address for clarity, I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants