Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How much ignored messages should be within a regular expression until the performance gets down? #108

Open
josefglatz opened this issue May 13, 2024 · 2 comments

Comments

@josefglatz
Copy link

Hi,

due to the fact that many exceptions are coming from 3rd party extension it's not that easy to fix all of them.

Is there a max number of messages which you put in the regular expression as a maximum value?

@christophlehmann
Copy link
Contributor

I bet preg_match() has a limit, never checked.

It could be cleaner to have a list of regular expressions (that needs to go to EXTCONF)

EXTCONF:
  sentry_client:
    ignoreMessageRegexp:
      # Bots on Powermail forms
      - 'Required argument.*mail.*Powermail.*FormController.*create'
      # Forbidden backend access (https://review.typo3.org/c/Packages/TYPO3.CMS/+/84726)
      - 'The IP address of your client does not match the list of allowed IP addresses'

What do you think?

@josefglatz
Copy link
Author

That looks very clean to me. However, do I understand correct: each array item represents an regex? With that approach it's also easily possible to add some regexps for exact matching and not exact matching which is pretty useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants