Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate pytest-redislite as a dependency #139

Closed
Kircheneer opened this issue Jul 22, 2022 · 2 comments
Closed

Re-evaluate pytest-redislite as a dependency #139

Kircheneer opened this issue Jul 22, 2022 · 2 comments
Labels
status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping

Comments

@Kircheneer
Copy link
Collaborator

Kircheneer commented Jul 22, 2022

Problem

The testing dependency pytest-redislite depends on redislite which brings with it a couple of problems:

  • No version that installs on M1 Macs out of the box, there are some workarounds you can perform but as per my experience they don't play too well with poetry
  • Latest release is about 1.5 years in the past
  • General signs of abandonment in the project, although that issue was closed the issues inside of it weren't really addressed yet

Potential solutions

  • Require docker-compose to run tests with Redis since we always have docker running anyway for development and then do away with mocking Redis, use pytest-redis?
  • Switch to something else for mocking Redis such as fakeredis-py?
@Kircheneer Kircheneer added status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping labels Jul 22, 2022
@Kircheneer
Copy link
Collaborator Author

I am now having additional issues here where redislite fails to install.

@Kircheneer
Copy link
Collaborator Author

Kircheneer commented Nov 3, 2022

Using pytest-redis and a locally installed redis for testing instead as of #176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant