Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/user/json/:userName/atlas api route doesn't work #306

Open
ntraut opened this issue Nov 5, 2021 · 0 comments
Open

/user/json/:userName/atlas api route doesn't work #306

ntraut opened this issue Nov 5, 2021 · 0 comments
Assignees
Labels

Comments

@ntraut
Copy link
Member

ntraut commented Nov 5, 2021

Thank you for your feedback.

Is it a [x] bug report or a [ ] feature request?

Current behaviour

  • If this is a bug, please explain how to reproduce the problem
    • Which tools did you use in which sequence?
    • Is the error concerning a text or a volume annotation?
    • Which label set has been used for the volume annotation (if applicable)?
    • What is the type and resolution of your data? (Can you provide a link to your data?)
    • Do not include sensitive information.
    • Upload the browser error message if you are familiar with web developer tools.

The route /user/json/:userName/atlas doesn't work since the function getUserAtlasSlice in dataSlices.js is buggy (use of for...in statement like if it were for...in and call to the i variable which is not initialized), so if we call it provided that we have some atlases we get the following json: {"success":false,"list":[]}.

That function is not used anywhere in brainbox except in the unit test 'should return the correct atlas slice with valid input', but since the user foo doesn't have any atlas, the test is happy because it gets an empty list with success=true

Expected behaviour

/user/json/:userName/atlas route should work correctly and the unit test should really test that an atlas slice is returned.

Version information (for bug reports)

current

@ntraut ntraut added the bug label Nov 5, 2021
@ntraut ntraut self-assigned this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant