Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile #348

Open
CorbinWunderlich opened this issue Oct 17, 2024 · 10 comments
Open

Unable to compile #348

CorbinWunderlich opened this issue Oct 17, 2024 · 10 comments

Comments

@CorbinWunderlich
Copy link

CorbinWunderlich commented Oct 17, 2024

rdpClientCon.c:827:18: error: 'XRDP_a8r8g8b8' undeclared (first use in this function); did yo>
827 | case XRDP_a8r8g8b8:
| ^~~~~~~~~~~~~
| PICT_a8r8g8b8
rdpClientCon.c:827:18: note: each undeclared identifier is reported only once for each functi>
rdpClientCon.c:828:18: error: 'XRDP_a8b8g8r8' undeclared (first use in this function); did yo>
828 | case XRDP_a8b8g8r8:
| ^~~~~~~~~~~~~
| PICT_a8b8g8r8
rdpClientCon.c:831:18: error: 'XRDP_r5g6b5' undeclared (first use in this function)
831 | case XRDP_r5g6b5:
| ^~~~~~~~~~~
rdpClientCon.c:832:18: error: 'XRDP_a1r5g5b5' undeclared (first use in this function); did yo>
832 | case XRDP_a1r5g5b5:
| ^~~~~~~~~~~~~
| PICT_a1r5g5b5
rdpClientCon.c:845:37: error: 'XRDP_r3g3b2' undeclared (first use in this function)
845 | clientCon->rdp_format = XRDP_r3g3b2;
|

I am compiling from source on NixOS. It has all the libraries it needs. I have enabled glamor and simd, but it did not work without them.

@CorbinWunderlich CorbinWunderlich changed the title 'struct xrdp_client_info' has no member named ___ Unable to compile Oct 17, 2024
@matt335672
Copy link
Member

You need to pick a version of xorgxrdp which is compatible with your installed version of xrdp.

It looks like you're trying to compile a recent version of xorgxrdp against an older version of xrdp.

@CorbinWunderlich
Copy link
Author

You need to pick a version of xorgxrdp which is compatible with your installed version of xrdp.

It looks like you're trying to compile a recent version of xorgxrdp against an older version of xrdp.

I am building xorgxrdp at v0.9.20, and xrdp at v0.9.25.1, is there anything wrong with this? I tried compiling the latest version, but it did not work. Thanks for your help. @matt335672

@CorbinWunderlich
Copy link
Author

I finally got it to build (I don't know how, I didn't change anything) but glamor doesn't work. The screen is just blank. It worked just fine without it. The cursor on the screen is the correct remote cursor.

@matt335672
Copy link
Member

I can think of two possibilities here:-

  1. Based on your description, make sure you haven't got a version of xrdp installed from a package, and a version you've built. If you do this, the shared libraries from one version get loaded by the other and bad things happen.
  2. Glamor doesn't work on all platforms, which is why we implemented glamor, check list of support devices #322.

@CorbinWunderlich
Copy link
Author

I can think of two possibilities here:-

1. Based on your description, make sure you haven't got a version of xrdp installed from a package, and a version you've built. If you do this, the shared libraries from one version get loaded by the other and bad things happen.

2. Glamor doesn't work on all platforms, which is why we implemented [glamor, check list of support devices #322](https://github.com/neutrinolabs/xorgxrdp/pull/322).

I am only using the new xrdp as a build input, not the already installed one. NixOS can do that very easily. As for the platform I am using, I am using i915-sriov as a guest vm. I assumed that was supported. Maybe it isn't thanks for the help.

@matt335672
Copy link
Member

Try disabling glamor at runtime by setting the DRMDevice to "" in /etc/X11/xrdp/xorg.conf`. That will tell you if it's glamor or not.

@CorbinWunderlich
Copy link
Author

Try disabling glamor at runtime by setting the DRMDevice to "" in /etc/X11/xrdp/xorg.conf`. That will tell you if it's glamor or not.

Where will it tell me that?

@matt335672
Copy link
Member

Sorry - not being clear. Setting the DRMDevice will tell you whether the the blank screen is a glamor problem, or whether something else is going on.

@CorbinWunderlich
Copy link
Author

Sorry - not being clear. Setting the DRMDevice will tell you whether the the blank screen is a glamor problem, or whether something else is going on.

It is still blank after setting DRMDevice.

@matt335672
Copy link
Member

The most likely thing is a build/runtime issue then.

I'm a bit concerned by this:-

I am only using the new xrdp as a build input, not the already installed one. NixOS can do that very easily

I'm not familiar with NixOS, so I can't comment on your assertion. However, because xrdp uses dynamic libraries built as part of the project, it's very easy to get in a mix over this.

I'd recommend starting with a system with no version of xrdp installed at all, and building both from scratch. We can sort out compilation issues as we go along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants