Fixing Node Group Configs

cluster-autoscaler/cloudprovider/gce/gce_manager.go

@@ -453,20 +453,26 @@
 						}
 					}
 					return err
 				} else {
 					// Skip migs whose instance templates don't have the corresponding config labels
+					var labelMismatch bool
 					for k, v := range cfg.Labels {
 						if instanceTemplate.Properties.Labels[k] != v {
 							klog.V(4).Infof("Instance template %s missing label %s=%s.\nIgnoring mig %s", instanceTemplate.Name, k, v, mig.GceRef().Name)
-							continue
+							labelMismatch = true
+							break
 						}
 					}
 
+					if labelMismatch {
+						continue
+					}
+
 					// Update the min size of mig config based on labels in the instance template
 					if val, ok := instanceTemplate.Properties.Labels[migAutoDiscovererKeyMinNodes]; ok {
 						if m, err := strconv.Atoi(val); err != nil {
 							return fmt.Errorf("invalid min nodes %s in instance template labels: %s", val, instanceTemplate.Name)
 						} else {
 							cfg.MinSize = m
 						}
 					}
@@ -475,10 +481,16 @@
 					if val, ok := instanceTemplate.Properties.Labels[migAutoDiscovererKeyMaxNodes]; ok {
 						if m, err := strconv.Atoi(val); err != nil {
 							return fmt.Errorf("invalid max nodes %s in instance template labels: %s", val, instanceTemplate.Name)
 						} else {
 							cfg.MaxSize = m
 						}
 					}
+
+					// Rebuild the mig with updated min and max sizes
+					mig, err = m.buildMigFromAutoCfg(link, cfg)
+					if err != nil {
+						return err
+					}
 				}
 			}
 
@@ -648,7 +660,7 @@
 		} else if labelEntryFound {
 			if c.Labels != nil {
 				return nil, fmt.Errorf("more than 1 label-based entry found in NodeGroupAutoDiscoverySpecs")
 			} else {
 				return nil, fmt.Errorf("label-based and name-prefix-based entries are both specified in NodeGroupAutoDiscoverySpecs")
 			}
 		} else if len(c.Labels) > 0 {