processor map values need - to prevent mapping to wrong processor #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfullen11
force-pushed
the
bugfix-cpu-platform
branch
from
c912394
to
93ba2ed
Compare
go fmt lint lint move processors to its own package and use it in machines move processors to its own package and use it in machines add package comment move get processor func to util fmt add period to comment simplify the pointer defref
cfullen11
force-pushed
the
bugfix-cpu-platform
branch
from
83b5927
to
2fefb6b
Compare
mytunguyen
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when mapping processors to instance types. When ranging over maps order is not guaranteed, even if order was enforced you could match instancetype abc to processor ab. By adding the hyphen we should ensure an exact prefix match.
Also added testing around this function we could add more testing in the future for the machine pools.