Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nri-bundle] [newrelic-logging] feat: added support for templated cluster name value #1287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pcanilho
Copy link

@pcanilho pcanilho commented Feb 19, 2024

Is this a new chart

No.

What this PR does / why we need it:

We're deploying the chart using ArgoCD and ApplicationSets with a cluster generator. To avoid having to bake NewRelic-specific logic into our wider ArgoCD Application generator, we need support for rendering cluster as a template variable in order to generate an appropriate value from generic values.

Which issue this PR fixes

This is a new feature.

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

Fixes #1288

@pcanilho pcanilho requested review from a team February 19, 2024 10:09
@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

@pcanilho pcanilho force-pushed the feature/support-templated-cluster-name branch from d36004a to a46b770 Compare February 19, 2024 10:16
@pcanilho pcanilho force-pushed the feature/support-templated-cluster-name branch from a46b770 to 750af9d Compare February 19, 2024 12:13
@pcanilho pcanilho requested a review from a team February 19, 2024 12:13
@@ -9,7 +9,7 @@ appVersion: 0.8.0

dependencies:
- name: common-library
version: 1.1.1
version: 1.1.2
Copy link
Member

@paologallinaharbur paologallinaharbur May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Just providing feedback on the chart we own]
modifying all charts at the same time is not allowed by the CI/CD
Moreover, the version was not bumped.


On the other hand, this change could be quite important and I'll leave the decision to the K8s team whether we actually want to support this use case (and then "how")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support templated [cluster] value
5 participants