Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/transaction/tracer/index.js to reduce duplicate logic #2504

Open
kmudduluru opened this issue Aug 20, 2024 · 1 comment
Open

Refactor lib/transaction/tracer/index.js to reduce duplicate logic #2504

kmudduluru opened this issue Aug 20, 2024 · 1 comment
Labels
points: 8 risk: high This change impacts critical areas or has other traits that warrant very careful consideration.

Comments

@kmudduluru
Copy link
Contributor

kmudduluru commented Aug 20, 2024 •
edited
Loading

Description

There currently is a lot of duplicated code in lib/transaction/tracer/index.js, specifically around input validation and wrapping of functions. We should abstract some of this duplicate logic into helper methods that allow us to write and test the logic once, and reuse in multiple places

Acceptance Criteria

Reduce duplicated logic for constructing a wrapper function(wrapFunctionNoSegment, wrapFunctionFirstNoSegment, wrapFunctionLast, wrapFunctionFirst, wrapFunction, wrapSyncFunction, and wrapCallback)

https://new-relic.atlassian.net/browse/NR-134520 see this ticket for any additional context
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-304774

@kmudduluru kmudduluru added points: 8 risk: high This change impacts critical areas or has other traits that warrant very careful consideration. and removed needs-triage labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
points: 8 risk: high This change impacts critical areas or has other traits that warrant very careful consideration.
Projects
Node.js Engineering Board
Status: Triage Needed: Unprioritized Features
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmudduluru