Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Logo sizing can fail on huge images #1084

Open
TylerFisher opened this issue Feb 8, 2022 · 3 comments
Open

Logo sizing can fail on huge images #1084

TylerFisher opened this issue Feb 8, 2022 · 3 comments
Labels
bug Something isn't working low priority

Comments

@TylerFisher
Copy link
Contributor

No idea why this math fails for larger numbers
@TylerFisher TylerFisher self-assigned this Feb 8, 2022
@TylerFisher
Copy link
Contributor Author

A huge image caused the logo in the GlobalNav component to render outside of its constraints. This caused the logo to basically take over the whole page.

@chelsea-tnc chelsea-tnc added bug Something isn't working low priority labels Jul 1, 2022
@chelsea-tnc
Copy link
Contributor

Repro steps:

  1. Go to https://[YOUR ORG]/tinycms/settings
  2. Upload a large image in the "Logo" section

Expected Result: The image should be resized in a responsive way
Actual Result: The image can take over the page or render in a non-responsive way

The workaround is to have the user resize the image a smaller size before uploading it.
This doesn't happen as often. This was covered in the walk-through with Tyler (see 26:55).

@chelsea-tnc chelsea-tnc mentioned this issue Jul 1, 2022
Open
@chelsea-tnc
Copy link
Contributor

This may have the same root cause as #1135

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerFisher @chelsea-tnc