Middleware doesn't prevent data fetching in root layout during auth redirect #12326

iqoOopi · 2024-12-01T06:43:05Z

iqoOopi
Dec 1, 2024

Description

When using Next.js middleware for authentication protection, data fetching calls in the root layout are still executed even when the middleware redirects to the login page. This can lead to unnecessary API calls and potential security concerns.

Reproduction Steps

Create a Next.js app with authentication middleware:

// middleware.ts
export { default } from 'next-auth/middleware';
export const config = {
matcher: ['/((?!public|signin).)'],
};

Add data fetching in root layout:

// app/layout.tsx
export default async function RootLayout({ children }: { children: React.ReactNode }) {
  // This API call still executes before next-auth can get a token. 
  // In my case, this call will need the jwt token from next-auth, but looks like the fetch call went out before next-auth got a jtw token. 
  thus the call is always fail. 
  
  // get token from session, and set to fetch header
  const data = await fetch('/api/protected-data');
  return (
    <html>
      <body>
        {/ Layout content /}
      </body>
    </html>
  );
}

I'm wondering is that middleware won't stop server side data fetching in root layout? My thoughts was auth middleware will redirect thus root layout won't get rendered thus no fetch call should get exectued

iqoOopi · 2024-12-01T07:06:05Z

iqoOopi
Dec 1, 2024
Author

Figured out, I have a custom signin page and of course it will trigger root layout to render first before user signin.....

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Middleware doesn't prevent data fetching in root layout during auth redirect #12326

{{title}}

Replies: 1 comment

{{title}}

Select a reply

Middleware doesn't prevent data fetching in root layout during auth redirect #12326

iqoOopi Dec 1, 2024

Description

Reproduction Steps

Replies: 1 comment

iqoOopi Dec 1, 2024 Author

iqoOopi
Dec 1, 2024

iqoOopi
Dec 1, 2024
Author