Fix package and add separate filepicker entry point #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…e.json Also move mdi dependency to dependencies instead of devDependencies Signed-off-by: Ferdinand Thiessen <[email protected]>
Instead export it in a `filepicker` entrypoint, also load the component async. in the filepicker builder. This ensures that if a user does not use the filepicker, it gets treeshaken. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
- Coverage 31.15% 30.44% -0.72%
==========================================
Files 15 16 +1
Lines 1194 1222 +28
Branches 60 61 +1
==========================================
Hits 372 372
- Misses 764 791 +27
- Partials 58 59 +1
|
1 task
Pytal
approved these changes
Oct 17, 2023
Pytal
reviewed
Oct 17, 2023
Comment on lines
-15
to
-17
| "./dist/index.css": { | ||
| "import": "./dist/style.css", | ||
| "require": "./dist/style.css" |
There was a problem hiding this comment.
Add that this is not needed in breaking changes @susnux ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filepickerentrypoint, also load the component async. in the filepicker builder. This ensures that if a user does not use the filepicker, it gets treeshaken.