Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker component can not be closed by click outside #1168

Closed
Antreesy opened this issue Jan 12, 2024 · 4 comments
Closed

FilePicker component can not be closed by click outside #1168

Antreesy opened this issue Jan 12, 2024 · 4 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file design & UX

Comments

@Antreesy
Copy link

After merging nextcloud-libraries/nextcloud-vue#5062 and bumping the vue-library:

  • prop closeOnClickOutside should be passed here (or be true by default):
    /**
    * Props to be passed to the underlying Dialog component
    */
    const dialogProps = computed(() => ({
    container: props.container,
    name: props.name,
    buttons: dialogButtons.value,
    size: 'large',
    contentClasses: ['file-picker__content'],
    dialogClasses: ['file-picker'],
    navigationClasses: ['file-picker__navigation'],
    }))
@Antreesy Antreesy added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 12, 2024
@Antreesy Antreesy added this to the 5.1.0 milestone Jan 12, 2024
@Antreesy Antreesy self-assigned this Jan 12, 2024
@susnux
Copy link
Contributor

susnux commented Jan 13, 2024

cc @jancborchardt

I am not sure about the UX here, see also my comment here nextcloud-libraries/nextcloud-vue#5062 (comment)

@susnux susnux modified the milestones: 5.1.0, 5.1.2 Feb 20, 2024
@susnux
Copy link
Contributor

susnux commented Apr 2, 2024

cc @nextcloud-libraries/developers

@susnux susnux removed this from the 5.1.2 milestone Apr 2, 2024
@jancborchardt
Copy link

Agree with @susnux’s assessment in nextcloud-libraries/nextcloud-vue#5062 (comment) – it is too risky and annoying to have changes vanish by accidentally clicking or tapping outside, even if it is just navigating into a sub-sub-subfolder and finally finding the file you were looking for. The X button is there and always there, it doesn’t need a huge "CLOSE" area around the whole dialog too. :)

@Antreesy
Copy link
Author

Ok, then I'm closing it

@Antreesy Antreesy closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file design & UX
Projects
None yet
Development

No branches or pull requests

3 participants