Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break in 5.3.3 with Nextcloud 28 and older #1418

Closed
nickvergessen opened this issue Aug 16, 2024 · 0 comments · Fixed by #1419
Closed

BC break in 5.3.3 with Nextcloud 28 and older #1418

nickvergessen opened this issue Aug 16, 2024 · 0 comments · Fixed by #1419
Labels
bug Something isn't working regression

Comments

@nickvergessen
Copy link
Contributor

nickvergessen commented Aug 16, 2024

I would therefore suggest to do the following:

  1. Branch of 5.3.5 as stable5
  2. Tag master/main as 6.0.0
  3. On stable5 revert the API change
  4. Release 5.3.6 and put it into stable28 of server: [stable28] fix(sharing): Pin @nextcloud/dialogs to a version that doesn't use Nextcloud 29 APIs nextcloud/server#47271

@ShGKme @susnux Sounds like the best option to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants