Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NodeData.source and NodeData.encodedSource #792

Closed
kesselb opened this issue Oct 3, 2023 · 1 comment
Closed

Remove NodeData.source and NodeData.encodedSource #792

kesselb opened this issue Oct 3, 2023 · 1 comment

Comments

@kesselb
Copy link
Contributor

kesselb commented Oct 3, 2023

After #789 and #790 encodedSource is mandatory.

This change will require some updates for server & apps.

Our current approach is to pass an uri like https://domain.com/remote.php/dav/files/emma/test/picture.jpeg as source to get basename, extension, dirname, root and path from it.

One disadvantage is that we lose all the semantics. That's difficult if we want to alter a part of the source, for example encode the path because it contains a special character.

Alternative:

  • Make NodeData.root required
  • Add NodeData.filename and NodeData.remoteUrl if necessary
  • Remove NodeData.source and NodeData.encodedSource
  • Change Node.source and Node.encodedSource to generate the urls / relative uris on the fly
@kesselb kesselb closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
@kesselb
Copy link
Contributor Author

kesselb commented Oct 3, 2023

We are going with a virtual getter for encodedSource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant