Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Esc key on Link picker dialog closes the document #4328

Open
pedropintosilva opened this issue Jul 12, 2023 · 4 comments
Open

Pressing Esc key on Link picker dialog closes the document #4328

pedropintosilva opened this issue Jul 12, 2023 · 4 comments
Assignees
@JuliaKirschenheuter
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: richtext Related to the richtext component feature: smart picker

Comments

@pedropintosilva
Copy link

Pressing Esc key on Link picker dialog closes the document instead of closing the dialog.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Insert tab'
  2. Click on 'Smart Picker'
  3. Now press Shift + Tab to got from the input to the previous element (close button)
  4. Press Escape key
  5. The document gets closed; we are now back to files view with that dialog still opened

Expected behavior
Escape should just close the dialog

  • server on #706c141fffce928d344fe2f039da549fad065393
  • richdocuments on fix/target-picker
  • viewer on #09996635005556bfc984de06d24568163b764a5d
@juliushaertl
Copy link
Contributor

Managed to reproduce this also with text, so this seems to be an issue of the shared vue components.

https://github.com/nextcloud/nextcloud-vue/blob/0e61454cf5f0c313409da4bc4645fb7fa8aaef2a/src/components/NcRichText/NcReferencePicker/NcReferencePickerModal.vue

Moving over to the component repo

@juliushaertl juliushaertl transferred this issue from nextcloud/richdocuments Jul 12, 2023
@juliushaertl juliushaertl added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: richtext Related to the richtext component feature: smart picker labels Jul 12, 2023
@juliushaertl
Copy link
Contributor

Seems that the modal listener might be too global and not preventing the escape event to propagate if two modals are open:

https://github.com/nextcloud/nextcloud-vue/blob/0e61454cf5f0c313409da4bc4645fb7fa8aaef2a/src/components/NcModal/NcModal.vue#L600-L615

In addition @julien-nc Do you remember why canClose was set to false in https://github.com/nextcloud/nextcloud-vue/blame/0e61454cf5f0c313409da4bc4645fb7fa8aaef2a/src/components/NcRichText/NcReferencePicker/NcReferencePickerModal.vue#L4?

@juliushaertl
Copy link
Contributor

Could not reproduce on tech-preview but on local master, so maybe something changed between 27 and master

@juliushaertl
Copy link
Contributor

No longer reproducable, just pressing esc on the close button does not work:

Likely the modal is not handling escape but the picker component:
https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcRichText/NcReferencePicker/NcReferencePickerModal.vue#L9
https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcRichText/NcReferencePicker/NcReferencePicker.vue#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: richtext Related to the richtext component feature: smart picker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliushaertl @JuliaKirschenheuter @pedropintosilva