From 9b85c45f38ad291194e5cfa1feae6fb41c5bfeeb Mon Sep 17 00:00:00 2001 From: Louis Date: Wed, 2 Oct 2024 16:39:36 +0200 Subject: [PATCH 1/2] fix: Don't require name prop in NcListItem As it is only required if the slot is missing. Signed-off-by: Louis --- src/components/NcListItem/NcListItem.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/NcListItem/NcListItem.vue b/src/components/NcListItem/NcListItem.vue index dcb0f6a45f..5827054164 100644 --- a/src/components/NcListItem/NcListItem.vue +++ b/src/components/NcListItem/NcListItem.vue @@ -563,7 +563,7 @@ export default { */ name: { type: String, - required: true, + default: undefined, }, /** From deef42b15a65fa562979a756a103930452a34114 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Thu, 3 Oct 2024 12:19:17 +0200 Subject: [PATCH 2/2] fix: Require actionsAriaLabel in NcListItem Signed-off-by: Louis Chemineau --- l10n/messages.pot | 3 --- src/components/NcListItem/NcListItem.vue | 9 ++------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/l10n/messages.pot b/l10n/messages.pot index fb61015786..da0ef21167 100644 --- a/l10n/messages.pot +++ b/l10n/messages.pot @@ -21,9 +21,6 @@ msgstr "" msgid "Actions" msgstr "" -msgid "Actions for item with name \"{name}\"" -msgstr "" - msgid "Activities" msgstr "" diff --git a/src/components/NcListItem/NcListItem.vue b/src/components/NcListItem/NcListItem.vue index 5827054164..1dda6d4455 100644 --- a/src/components/NcListItem/NcListItem.vue +++ b/src/components/NcListItem/NcListItem.vue @@ -514,7 +514,7 @@ The `actions-icon` slot can be used to pass icon to the inner NcActions componen