Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guests can't see files when Collectives are enabled #863

Closed
enoch85 opened this issue Sep 6, 2023 · 16 comments · Fixed by #1015
Closed

Guests can't see files when Collectives are enabled #863

enoch85 opened this issue Sep 6, 2023 · 16 comments · Fixed by #1015
Labels
0. Needs triage bug Something isn't working

Comments

@enoch85
Copy link
Member

enoch85 commented Sep 6, 2023

Actual behavior

When using the guests app in combination with Collectives newly invited guest can only see this:
image

Creating a regular user (non admin or admin) doesn't have this behavior, everything shows up as normal.

We checked the Collectives app as a guest user, and even if a Collective is created, it still aren't aware of the mapping for the Collectives folder. It just says something like "Please create a Collective to be able to choose location". Non-guest users doesn't have this issue though.

image

What we tried:

  1. Remove all the limitations in the Guests app
  2. Disable Collectives app

In both cases, the same issue appears.

Expected behavior

When a new user is invited, they should be able to see everything, just as a normal user.

Settings:

image

Nextcloud version
27.0.2

PHP
8.2

Server
Ubuntu server 22.04

@enoch85 enoch85 added bug Something isn't working 0. Needs triage labels Sep 6, 2023
@small1
Copy link

small1 commented Sep 6, 2023

To add information.

If you are a guest you typically dont have any rights to create folders or files. But if someone shares something to you you have that.

The skeleton folder doesn't seem to be copied in for guests. And apps like collectives cant create the /Collectives folder that is necessary for the app to work as it should.

There need to be some special handling for apps that needs a folder to be there for mount points. Like Collectives or if you create a special folder where content should be shared to.

Not sure if this belongs here or if we should create bugs in the other repositories as well.

@juliushaertl
Copy link
Member

I would move this to the collectives app, as the fix should be applied there

@juliushaertl juliushaertl transferred this issue from nextcloud/guests Sep 6, 2023
@small1
Copy link

small1 commented Sep 6, 2023

@juliushaertl it also affects if you have files shared to a folder we have one called "/Shared with me" in this case. That doesnt work either.

@juliushaertl
Copy link
Member

In that case a separate bug report in server (for the files_sharing app) would be appreciated

@enoch85
Copy link
Member Author

enoch85 commented Sep 6, 2023

@small1 Can you create the issue report on server an link it here please?

@quenenni

This comment was marked as off-topic.

@max-nextcloud

This comment was marked as off-topic.

@quenenni

This comment was marked as off-topic.

@max-nextcloud
Copy link
Collaborator

Removed the logs from the description as the exception thrown there is tracked in #828 and fixed now.

@enoch85 Could you check if the latest release of collectives (2.7.1) also fixed this issue for you?

@enoch85
Copy link
Member Author

enoch85 commented Sep 14, 2023

@max-nextcloud It's 50% solved.

Users can now see shared documents, but they still get the message "This folder is best shown in Collectives", and "You don't have permission to upload anything here".

Screenshot_2023-09-14-08-27-50-97_3aea4af51f236e4932235fdada7d1643

@max-nextcloud
Copy link
Collaborator

How did you invite the guest users?
My understanding is that they typically are granted access by sharing a file with them. Is that what you did? Which file did you share? Is it part of a collectives folder or so?

The message "You don't have permission to upload anything here" is correct, right? I mean these are guest accounts and they are not in a writeable share folder.

@small1
Copy link

small1 commented Sep 14, 2023

We invite them in the guests app. What happens is that the collective folder can't be created and thus thinks that / should be the folder to store everything in.

If we create that manually and scan the users files it will work as it should

@enoch85
Copy link
Member Author

enoch85 commented Sep 14, 2023

@max-nextcloud

Yes, user was "created" (rather activated) by sharing Testdockument.txt through email to my own user [email redacted].

I'm not sure about the permissions, but you're probably right. Though the file is not part of Collectives and has nothing to do with Collectives at all.

@max-nextcloud
Copy link
Collaborator

Hum... just a wild guess. Maybe collectives cannot create the folder for it's mountpoints - falls back to the root folder and from there on thinks all folders are belong to it.

Funny thing is that we have not observed this behavior on our own instance with guest users.

@max-nextcloud
Copy link
Collaborator

@enoch85 Could you share the Collectives folder with them? I'd be curious what happens then:

  • The user should now have a folder with the correct name to put collectives into. So maybe it stops treating the root folder as one?
  • The folder contains the mount points of your own collectives. I don't know if they will be shared as well. Would be curious to hear.

@small1
Copy link

small1 commented Sep 14, 2023

@max-nextcloud I did that test when we filed the bug. Folder wasn't created. It started working correctly after we created the collective folder manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants