Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace build image with bind mount #2278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace build image with bind mount #2278

wants to merge 1 commit into from

Conversation

SebastianRzk
Copy link

@SebastianRzk SebastianRzk commented Aug 18, 2024 •
edited
Loading

A separate image is currently being built for the nginx proxy (service name: web). According to my information, this is not necessary, but even counterproductive

Why?

  • The image does not need to be built (why should it?)
  • Fewer files and less code = easier maintenance and fewer potential bugs
  • the container can be easily updated (for example via a program like watchtower)

@SebastianRzk SebastianRzk mentioned this pull request Aug 18, 2024
Open
@joshtrichards joshtrichards linked an issue Aug 18, 2024 that may be closed by this pull request
Replace custom nginx image with bind mount #2279
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace custom nginx image with bind mount
1 participant
@SebastianRzk