Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect hour for Calendar #91

Closed
Thovi98 opened this issue Nov 29, 2021 · 13 comments
Closed

incorrect hour for Calendar #91

Thovi98 opened this issue Nov 29, 2021 · 13 comments
Labels

Comments

@Thovi98
Copy link

Thovi98 commented Nov 29, 2021

Hello @eneiluj,
Thanks a lot for this very useful app !!

I have only one problem : when I import from a Google calendar, the calendar import well, but with the false time : every event is set one hour sooner (maybe a timezone issue ?).
Google:
2021-11-29 20_00_04-Google Agenda - décembre 2021

Same calendar after import to Nextcloud:
2021-11-29 20_00_17-décembre 2021 - Agenda - Nextcloud

@treed
Copy link

treed commented Jan 18, 2022

I experience this issue too. Looking back, it only occurs for the part of the year which doesn't have daylight saving time (summer time, I think it's called in Europe). Entries during DST have the correct time.

@ant0nwax
Copy link

+1

@Naxdy
Copy link

Naxdy commented Nov 17, 2022

same problem, time is messed up during winter (non-DST), also EU

@julien-nc
Copy link
Member

It works fine on my side.

In google calendar

image
image
Event ics start date (from calendar export): DTSTART:20221222T090000Z

In Nextcloud

image
Event ics start date (from event export): DTSTART;VALUE=DATE-TIME:20221222T090000Z

Could someone also check the ics values on both side?

@julien-nc julien-nc added bug Something isn't working question Further information is requested labels Dec 23, 2022
@shalak
Copy link

shalak commented Feb 11, 2023

I have it even weirder: some events are 1-hour off, and some are not.

Extracted from nextcloud:
This one is off-by-one hour (original was at 17:00 Warsaw TZ)

BEGIN:VEVENT
DTSTAMP:20230211T211620Z
UID:[email protected]
SUMMARY:my summary
DESCRIPTION:
ORGANIZER:mailto:[email protected]
LOCATION:
STATUS:CONFIRMED
DTSTART;TZID=Europe/Warsaw:20150610T170000
DURATION:PT3600S
RRULE:FREQ=DAILY;WKST=SU;INTERVAL=10
BEGIN:VALARM
TRIGGER:PT0S
ACTION:DISPLAY
DESCRIPTION:my summary

This one is OK:

BEGIN:VEVENT
DTSTAMP:20230211T211620Z
UID:[email protected]
SUMMARY:another summary
DESCRIPTION:
ORGANIZER:mailto:[email protected]
LOCATION:
STATUS:CONFIRMED
DTSTART;TZID=Europe/Warsaw:20200115T200000
DURATION:PT3600S
RRULE:FREQ=WEEKLY;WKST=MO;INTERVAL=4;BYDAY=WE
BEGIN:VALARM
TRIGGER:-PT1440M
ACTION:DISPLAY
DESCRIPTION:another summary
END:VALARM
BEGIN:VALARM
TRIGGER:-PT2880M
ACTION:DISPLAY
DESCRIPTION:another summary
END:VALARM
END:VEVENT

The originals, exported from google:

The original one that is off-by-one hour:

BEGIN:VEVENT
DTSTART;TZID=Europe/Warsaw:20181023T191500
DTEND;TZID=Europe/Warsaw:20181023T201500
DTSTAMP:20230212T023338Z
UID:[email protected]
RECURRENCE-ID;TZID=Europe/Warsaw:20181022T170000
CREATED:20150610T111119Z
DESCRIPTION:
LAST-MODIFIED:20230129T160013Z
LOCATION:
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:my summary
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:P0D
END:VALARM
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Europe/Warsaw:20190321T164500
DTEND;TZID=Europe/Warsaw:20190321T174500
DTSTAMP:20230212T023338Z
UID:[email protected]
RECURRENCE-ID;TZID=Europe/Warsaw:20190321T170000
CREATED:20150610T111119Z
DESCRIPTION:
LAST-MODIFIED:20230129T160013Z
LOCATION:
SEQUENCE:3
STATUS:CONFIRMED
SUMMARY:my summary
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:P0D
END:VALARM
END:VEVENT

The original correct one:

BEGIN:VEVENT
DTSTART;TZID=Europe/Warsaw:20200115T200000
DTEND;TZID=Europe/Warsaw:20200115T210000
EXDATE;TZID=Europe/Warsaw:20200311T200000
EXDATE;TZID=Europe/Warsaw:20200408T200000
RRULE:FREQ=WEEKLY;INTERVAL=4;BYDAY=WE
DTSTAMP:20230212T023338Z
UID:[email protected]
CREATED:20190703T192915Z
DESCRIPTION:
LAST-MODIFIED:20230207T190150Z
LOCATION:
SEQUENCE:5
STATUS:CONFIRMED
SUMMARY:another summary
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P1D
END:VALARM
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P2D
END:VALARM
BEGIN:VALARM
ACTION:NONE
TRIGGER;VALUE=DATE-TIME:19760401T005545Z
END:VALARM
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Europe/Warsaw:20220630T195000
DTEND;TZID=Europe/Warsaw:20220630T205000
DTSTAMP:20230212T023338Z
UID:[email protected]
RECURRENCE-ID;TZID=Europe/Warsaw:20220629T200000
CREATED:20190703T192915Z
DESCRIPTION:
LAST-MODIFIED:20230207T190150Z
LOCATION:
SEQUENCE:6
STATUS:CONFIRMED
SUMMARY:another summary
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P1D
END:VALARM
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P2D
END:VALARM
END:VEVENT

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Hello 👋
This issue appears to have had no activity for 3 months. We cannot keep track of whether individual issues
have resolved themselves or still require attention without user interaction. We're thus adding the stale label to this issue to schedule
it for getting closed in 5 days time. If you believe this issue is still valid and should be fixed, you can add a comment
or remove the label to avoid it getting closed.

Cheers 💙

@github-actions github-actions bot added the Stale label Jun 1, 2023
@shalak
Copy link

shalak commented Jun 1, 2023

The issue is still valid and should be fixed.

@marcelklehr marcelklehr removed the Stale label Jun 1, 2023
@marcelklehr
Copy link
Member

@shalak Thank you! I will take a look soon.

@marcelklehr
Copy link
Member

This one is off-by-one hour (original was at 17:00 Warsaw TZ)
[...]
DTSTART;TZID=Europe/Warsaw:20150610T170000

The export suggests that the ground truth in nextcloud is exactly 5pm Warsaw time. If this event is displayed wrong in your nextcloud UI, then you might have the wrong timezone set. Can you check in your calendar settings?

@marcelklehr
Copy link
Member

marcelklehr commented Jun 2, 2023

@shalak Also, the exported time data is completely different between your nextcloud export and the exported original from google. It seems rather unlikely that these are actually the same event:

Google (also note that these are two events):

DTSTART;TZID=Europe/Warsaw:20181023T191500
DTEND;TZID=Europe/Warsaw:20181023T201500
...
DTSTART;TZID=Europe/Warsaw:20190321T164500
DTEND;TZID=Europe/Warsaw:20190321T174500

Supposed equivalent nextcloud event:

DTSTART;TZID=Europe/Warsaw:20150610T170000

@marcelklehr marcelklehr removed the question Further information is requested label Jun 2, 2023
@marcelklehr
Copy link
Member

All this being said, I could also not reproduce this offhand. I created an event in google on June 1st, 12pm Kiev time and on Feb 1s 12pm Kiev time. After import, both are 11pm, but only because Nextcloud thinks I'm in Berlin timezone. When I change this to Kiev time, both are correct.

@shalak
Copy link

shalak commented Jun 2, 2023

Did you try to import those exact two events that I posted? (those after the The originals, exported from google in my comment)

@marcelklehr
Copy link
Member

I've managed to reproduce this now. It appears not to be an import bug but a bug in calendar, this becomes clear when you change the time zone in calendar to a zone that doesn't have DST. See nextcloud/calendar#5031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants