-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 support #1542
Comments
Yes, that's actually the next item on my todo list :) I'm surprised, this happens, though. NC 23 is still supported and doesn't support PHP 8 iirc. That would mean that these apps don't respect the support cycle of NC itself... 🤔 |
I've already updated to php 8 due to the passwords app ,@Jannik44 mentioned, requires it. I think everything works ok, but that's for my private cloud. The only thing I noticed is the ncp diagnostics show php was down. I assume this issue should also go away then, right? So just wait for an ncp update. |
@Oberlurch3000 I can't promise that, but very likely, yes. The difficult thing with the php upgrade is, that I need to ensure, that all the config files are migrated and the settings pertained (that caused issues with uploading larger files in the past, for example). Therefore I'm migrating all relevant config files to a new system that has been in place for a while but not yet used by all config files. I'll give you more specific instructions on the safest way to upgrade once I'm done |
@Oberlurch3000 Alright, so I have a working upgrader now at the
apt-get install --no-install-recommends php-{common,igbinary,redis} "php7.4" "php7.4"-{curl,gd,fpm,cli,opcache,mbstring,xml,zip,fileinfo,ldap,intl,bz2,json,common,readline,mysql,bcmath,gmp}
Best of luck! |
@theCalcaholic Ok, backup done. Now I'll see if it works for me. My instance is already on 24.0.4. Is that a problem? |
Yeah, it won't perform the upgrade in this case. It's probably better to disable automatic nc updates (you can keep automatic ncp updates) and wait for the next NC release. |
I've no automatic updates enabled. I'm just a curious and impatient guy :D. I get this when performing OUTPUT```root@nextcloudpi:/home/pi# ncp-update feature/php8
|
@Oberlurch3000 The output looks good, but the PHP upgrade will only be performed on the next nextcloud upgrade (performed with |
@Jannik44 You could try the php upgrade if you like. Just follow the instructions above (quoted for your convenience).
|
Update: This feature will soon get merged to devel (see #1554 ) |
Thanks, worked fine for me too, can we still keep |
Please don't use the feature/php8 branch anymore. Changes are now in devel. If you updated to the feature/php8 branch from any version of NCP prior to v1.49.1, you need to do the following ncp-update
ncp-update devel Afterwards, run the nc-limits app from ncp-config (CONFIG -> nc-limits). |
PHP 8 support is now in master and included in v1.50.0 |
So just updating NCpi via |
Precisely. However, the new images aren't ready yet because of an issue with my deployment pipeline (cross architecture tests fail) which means that docker installations can't be updated yet |
This happens if I perform the updates on a system with php8 already installed:
|
I installed 1.50.0, but php 8 is not activated (still php 7.4). I have the normal ncp version (no docker). According to the changelog php should work. Do I have to run something else too and not only |
I have the same message as @Oberlurch3000 but I updated php7.3 to php7.4 in july and get
I have nextcloudpi 24.0.4.1 installed on a dietpi debian |
Manually updating your PHP version will cause these kinds of issues. However, you will have to wait until #1570 is fixed, before performing |
@theCalcaholic I found that /usr/local/etc/ncp.cfg was the culprit. There php_version, release, etc. had the old values. thank you for your help and work on ncp |
Could you explain what you mean with old values? |
@Oberlurch3000 If you upgrade PHP manually, NCP won't know about it and will try to work with a wrong version of PHP. If you are lucky, however, editing ncp.cfg will let the PHP upgrade succeed when you run Generally, it is not advisable to configure ncp in any way except with the official ncp tools (web UI, ncp-config), unless you are completely sure that what you're doing will not affect other ncp components. |
for my case I moved late to bullseye and did this with apt dist-upgrade and not with ncp-dist-upgrade. so my ncp.cfg didn't updated and as I was on php 7.4 in the meantime I got old ncp.cfg:
switched to ncp.cfg:
and could update with as @theCalcaholic expalined, you could be lucky too if you change your |
@theCalcaholic so since my ncp was expecting php 7.4 the workflow should look like?:
That's all? |
@Oberlurch3000 sounds about right. Allthough I'd assume, that the process you suggested is more reliable. |
So this is confusing... I tried to go the easy way first just editing the I'm pretty sure I restarted the whole raspi last time I changed the |
Hi there - it's been a while since I postponed this update. |
Hello, is it planned to support php8.0 within the next weeks? We really need it, more and more apps arent running with php 7 anymore, for example my password manager app, it crashes without php8.0 and a manual upgrade failed, so is this planned in the next time?
The text was updated successfully, but these errors were encountered: