-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unselect all button #1895
Merged
Merged
Add unselect all button #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
enhancement
New feature or request
javascript
Javascript related ticket
2. developing
Work in progress
labels
Jun 19, 2023
artonge
force-pushed
the
artonge/feat/add_unselect_all
branch
from
July 4, 2023 14:43
64987b2
to
cb3a3ff
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jul 5, 2023
artonge
force-pushed
the
artonge/feat/add_unselect_all
branch
from
July 5, 2023 12:46
cb3a3ff
to
53194d9
Compare
/backport to stable27 |
backportbot-nextcloud
bot
added
the
backport-request
Pending backport by the backport-bot
label
Jul 5, 2023
/backport to stable26 |
/backport to stable25 |
artonge
requested review from
a team,
susnux,
Pytal and
Fenn-CS
and removed request for
a team
July 5, 2023 12:55
Fenn-CS
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
backport-request
Pending backport by the backport-bot
enhancement
New feature or request
javascript
Javascript related ticket
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Unselect all" button.
I went the easy way, as dynamically displaying action from the three dot menu based on the available space would require some changes in
@nc/vue
I also took the opportunity to prevent selection in Places and Public album views as no actions can be done from those.