Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a default view #573

Closed
szaimen opened this issue Nov 28, 2020 · 12 comments
Closed

Define a default view #573

szaimen opened this issue Nov 28, 2020 · 12 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@szaimen
Copy link
Contributor

szaimen commented Nov 28, 2020

Is your feature request related to a problem? Please describe.
As an admin I would like to define a default view for my users.

Describe the solution you'd like
Great would be having an admin setting for this app to define a default view for anyone when opening the photos app, so that e.g. Your folders can get opened by default.

Describe alternatives you've considered
Alternatively, each user should be able to choose a default view by opening the photos settings.
This is how the Tasks app handles a default list for reference:
image

@szaimen szaimen added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 28, 2020
@skjnldsv
Copy link
Member

Hey :)

As an admin I would like to define a default view for my users.

I failed to see why an admin would enforce such thing. For me it would be just as bad as the current state.
Why would the admin choice be more suitable than the current default? :)

@skjnldsv skjnldsv added the needs info Not enough information provided label Nov 30, 2020
@skjnldsv
Copy link
Member

@jancborchardt what do you think? :)

@szaimen
Copy link
Contributor Author

szaimen commented Nov 30, 2020

Why would the admin choice be more suitable than the current default? :)

Because Your photos is always empty for all users on my installation and Your folders is not. Hence Your folders is the better choice on my instance, imo :)

I just want to show them that there are indeed photos that can be shown when opening the photos app but due to #154 (comment) the photos app appears empty when opening the app.
I understand that this was done because of performance issues but Your folders works on my instance hence I would like to make it the default.

I hope that makes it a bit clearer :)

@skjnldsv
Copy link
Member

skjnldsv commented Nov 30, 2020

Because Your photos is always empty for all users on my installation

Isn't that the root issue instead? ^^
Why is this empty? :) Got it now!

@skjnldsv
Copy link
Member

Yeah, for me this is not the way to go. We need to promote the Timeline as this is the new feature and was the most requested one. The ext storage issue needs to be fixed instead.

@szaimen
Copy link
Contributor Author

szaimen commented Nov 30, 2020

The ext storage issue needs to be fixed instead.

Well, this is of course a solution but I still think that Your folders is better suited for my instance also if the timeline would work because of the raw amount of photos I am storing in Nextcloud (or have connected to Nextcloud). I don't consider the timeline view really useful if I have to scroll very far to view different folders (when they have many pictures inside). The Your folders view represents the folder structure better and is thus better understandable for the normal user and also much faster to navigate, imo. :)

@szaimen
Copy link
Contributor Author

szaimen commented Nov 30, 2020

So what do you think @skjnldsv? :)

@skjnldsv
Copy link
Member

I'm not fond of this.
Otherwise this would apply to all apps. Why not add an option to select the default mail account, or files view, or contacts group, or calendar... etc :)
Adding this will just add one more setting that will most likely barely be used.

@szaimen
Copy link
Contributor Author

szaimen commented Nov 30, 2020

Why not add an option to select the default mail account, or files view, or contacts group, or calendar... etc :)

Actually, most of them make sense, at least on a per user basis, imo :)

Here is e.g. the request for the calendar app: nextcloud/calendar#1835

But let's wait for @jancborchardt what he sais :)

@skjnldsv
Copy link
Member

I'll post this here :p

image

@jancborchardt
Copy link
Member

jancborchardt commented Dec 10, 2020

Sorry for my absence, was out for the last week. :)

So as @skjnldsv already said, we shouldn’t add a setting for this, especially not for the admin as this is quite irrelevant for admins, and even users shouldn’t need to bother about it.

The solution is quite simple: The app should simply remove the last view you had open. That is, if you were in "Your folders" and close the tab, or go to another app in Nextcloud, the next time you open Photos it should go to "Your folders" again. That way @szaimen in your case the first run is still the intended way (and yes #154 (comment) should be fixed instead as the root issue), but going forward, the preferences of people will automatically be picked up.

(This is also the way to go for other apps btw, could possibly be in a "state" component? Not sure if it makes sense @skjnldsv)

@szaimen
Copy link
Contributor Author

szaimen commented Dec 10, 2020

So then, let's close this in exchange for #271?

@skjnldsv skjnldsv removed the needs info Not enough information provided label Dec 11, 2020
@jancborchardt jancborchardt removed their assignment Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants