Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to multiple files at once (bulk edit option) #10674

Closed
Snake883 opened this issue Aug 13, 2018 · 29 comments
Closed

Add tags to multiple files at once (bulk edit option) #10674

Snake883 opened this issue Aug 13, 2018 · 29 comments

Comments

@Snake883
Copy link

I want to select multiple files and add tags to those files.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10258 (files dates ( enhancement )), #10673 ([enhancement] Pin File Details Pane ), #1791 (show shared files with full path - enhancement), #10194 (multiple attachments), and #10649 (Enhancement: more sorting options in file app. ).

@MorrisJobke MorrisJobke changed the title [enhancement] Tag Multiple Files Add tags to multiple files at once (bulk edit option) Aug 20, 2018
@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@laurentiu2
Copy link

Would be a great feature! What about this approach?

screenshot 2019-02-26 at 20 00 31

@jancborchardt
Copy link
Member

@laurentiu2 sure, looks good! :)

  • It should say "Tags"
  • Be sorted between "Download" and "Delete"
  • Use "icon-tag" for the icon instead of the same as Move/copy

@Kurlee
Copy link

Kurlee commented Apr 5, 2019

Is anyone working on this feature? I am working on a project that would greatly benefit from this feature. I have a dev or two here that can help out if someone wants to point us in the right direction

@wiswedel
Copy link
Contributor

wiswedel commented Apr 8, 2019

@Kurlee Thanks for your initiative. We'll be happy to assist you with the direction.
Do you already have concrete questions?

@wiswedel
Copy link
Contributor

wiswedel commented Apr 8, 2019

Would be a great feature! What about this approach?

screenshot 2019-02-26 at 20 00 31

@skjnldsv

@Kurlee
Copy link

Kurlee commented Apr 8, 2019

@Kurlee Thanks for your initiative. We'll be happy to assist you with the direction.
Do you already have concrete questions?

Is there an offline channel I can discuss with you? I am on the dev IRC and the help forums

@wiswedel
Copy link
Contributor

wiswedel commented Apr 8, 2019

Is there an offline channel I can discuss with you?

@Kurlee Since we're Open Source, why not discuss here in public?

@Kurlee
Copy link

Kurlee commented Apr 8, 2019

@Kurlee Since we're Open Source, why not discuss here in public?

Sounds good! So we have a good grasp of the API and how to implement bulk tagging using a curl script and webdav, but obviously, this is a bandaid.
It looks like the client triggers the call to add the tag in the db with the js scripts in the systemtags file.
We are unsure about how to copy the bulk move/copy function in bulk because we are having an issue figuring out how the multi-select feature and these calls work together, and the function flow path.

We might be over our heads in this but we are dedicated to figuring it out and making a contribution to this project

@wiswedel
Copy link
Contributor

wiswedel commented Apr 9, 2019

@jancborchardt Do you think you can assist here a bit?

@jancborchardt
Copy link
Member

Sorry but this is out of my expertise – someone from @nextcloud/javascript would have to help @Kurlee here. :)

@Kurlee
Copy link

Kurlee commented Apr 18, 2019

So more specifically (after poking around a bit), we just are having a hard time sorting out how the selected files are passed to client.js. Selecting function and menu all seem to be handled by jquery. Stepping through the functions is very difficult with jquery so I am stalled a bit. I think I would only need a few mins of time from someone who knows what they are doing to get over this hump and move forward.

@jancborchardt
Copy link
Member

Who is the right person to help @Kurlee here @rullzer @MorrisJobke? :)

@Kurlee
Copy link

Kurlee commented Apr 19, 2019

Made some progress on this today and answered some of the questions I had yesterday.
The menu is generated by app/files/js/filelist.js
However I assume that app/files is primarily for handling all file actions, would I be doing this improperly if I simply worked within the app/files directory to add this functionality?
I can hack it together to get it working but I want to be a good contributor :)

@grasponcrypto
Copy link

grasponcrypto commented Jun 23, 2019

any progress made here? This would be a huge help to catalogue my pictures. I'd be willing to help beta test and submit issues and fix bugs if necessary.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jul 1, 2019
@HFranz
Copy link

HFranz commented Sep 9, 2019

waiting for this feature too

@derKroisi
Copy link

any news for this feature? would love to see it, or get some informations on the plans

@rizerzero
Copy link

Would love to see this feature too !

@rolandinus
Copy link

I would be happy to spend some developing time on it. May be we could join efforts here.
I am not sure if it is possible to hook into the menu and add an extra menu option via an custom app? Then we could add this functionality without changing the core.

@rullzer
Copy link
Member

rullzer commented Nov 14, 2019

As always. If somebody wants to pick this up and propose a PR this is most welcome.

@rolandinus
Copy link

Is there someone who could help me with the failed automatic tests?
The failed tests do not seem to be related to code changes I made
I am new to contributiong to nextcloud, so would be thankful if someone could guide me here a bit

@wiswedel
Copy link
Contributor

wiswedel commented Dec 3, 2019

Is there someone who could help me with the failed automatic tests?
The failed tests do not seem to be related to code changes I made
I am new to contributiong to nextcloud, so would be thankful if someone could guide me here a bit

CC @nextcloud/server-triage

@caseyhoward
Copy link

This would be very helpful especially since even tagging one file is extremely painful. Unless I'm missing something it requires 5 clicks:

  1. Context menu button for file
  2. "Details" in the menu
  3. Menu button for details section
  4. "Tags" in the menu
  5. The tag input field since it doesn't auto-focus.

@digititus
Copy link

Would love to see this implemented! Tagging a new system now and it is extremely slow with large data set of files

@bjoern-tantau
Copy link

For what it's worth, I've been working on a plugin to assign tags to multiple files at once. It hooks into some JS functions in a pretty hacky way and there are some visual glitches and it does not work well on mobile. But I don't have enough time to polish it so I wanted to at least publish the code in the hopes that it's useful for someone or maybe someone could even polish it: https://github.com/bjoern-tantau/massassigntags

Code is licensed under the AGPL. I should actually add a license file to it, but it's reflected in the composer.json.

@skjnldsv
Copy link
Member

#28133

@olaulau
Copy link

olaulau commented Sep 25, 2024

as of today, this feature isn't yet on my nextcloud files (v 29.0.6.1)

@rolandinus
Copy link

It seems "done" means in this case, it is merged with another issue, which ist still open:
#45935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests