[Bug]: After upgrade to 28.0.1 nonstop errors regarding guestName avatar #42858
Comments
JRGonz
added
0. Needs triage
JRGonz
changed the title
|
I think server/lib/private/Contacts/ContactsMenu/ContactsStore.php Lines 341 to 345 in 23a7f8c The route expects guestName to have a value: Line 56 in 23a7f8c I suspect it'll go away if you change EDIT: Might be a couple other spots where the use of |
|
Any idea on the underlying cause? Is this related to LDAP auth? Is this an actual bug? Maybe a combination of the two? I just don't understand why it is pulling a guest avatar from an LDAP authenticated user. This is flooding my logs as an error and I guess 28 keeps an error in log count that doesn't go away for a week. Otherwise everything is functional but I really would like to know what this is related to. I mean with my limited knowledge it almost looks as though it is first searching the local system side for avatars but then not finding it and then snatching the avatar from LDAP (which the server has) and plugging it in so LDAP users have avatars. Maybe I am wrong though. |
Outside of making that area of code noted a bit more robust to empty name fields that reach it? No. Well, I suppose having guest users with empty name fields. :-)
Not sure. Handling of empty name fields at this point in the code could be more robust. That would eliminate the error you're seeing, but unclear whether it's expected that you have guest users with empty name fields in your environment. :-)
This area of code looks to be generating the contacts menu, so it's looking up everyone's avatars - including for any guests you have added - and not just the currently authenticated user's avatar. It doesn't sound like you've experienced any other symptoms, so that's a good sign.
What version of Nextcloud did you upgrade from? EDIT: Didn't mean to close. |
|
I created a test guest user a while back just for testing but then deleted the user. That was quite a while ago. This issue happened both when enabled and disabled. I actually disabled it at the time because I was suspecting that may possibly have been the cause. I went from 27 (latest forgot exact version) to 28.0.1. Is there a way to possibly hunt down remnants of guest users in the db and possibly remove them or from occ to check that? Maybe it's just something lingering in the db? |
sudo -u www-data php --define apc.enable_cli=1 /var/www/cloud.domain.tld/occ guests:listNo guests created I'm guessing because no guests exist. |
Fixes #42858 and makes things more robust Signed-off-by: Josh <[email protected]>
|
I applied the changes manually and so far no errors in the log (which would pop up on any access to anything in the web ui). After truncating the Nextcloud log I now have a green checkmark in the admin page. I will keep an eye on it but it seems fixed. |
No, an upstream dependency changed exit code requirements. Fix pending in nextcloud/guests#1101 |
Fixes #42858 and makes things more robust Signed-off-by: Josh <[email protected]>
|
The other matter fixed in nextcloud/guests#1102 and will be in the next release. |
Bug description
After upgrading I noticed that the nextcloud administration status page showed errors that were constantly counting up. Looking at the logs (had to disable ad blocker to see them for some reason) It was showing the following error...
InvalidParameterException
Parameter "guestName" for route "core.GuestAvatar.getAvatar" must match "[^/]++" ("" given) to generate a corresponding URL.
I am not really sure where to look here. Maybe it is related to auth against ldap? I haven't been able to find any more information about it.
Steps to reproduce
Just run nextcloud and it will constantly log this.
Expected behavior
To not have this error.
Installation method
Community Manual installation with Archive
Nextcloud Server version
28
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.2
Web server
Apache (supported)
Database engine version
MySQL
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 22 to 23)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
{ "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "cloud.domain.tld" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "default_phone_region": "US", "dbtype": "mysql", "version": "28.0.1.1", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/cloud.domain.tld", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauth": 1, "mail_smtpauthtype": "PLAIN", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "587", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "enable_previews": true, "enabledPreviewProviders": [ "OC\\Preview\\Movie", "OC\\Preview\\TIFF", "OC\\Preview\\HEIC", "OC\\Preview\\Image" ], "preview_max_x": "2048", "preview_max_y": "2048", "jpeg_quality": "60", "memcache.local": "\\OC\\Memcache\\APCu", "filelocking.enabled": true, "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 0, "timeout": 0 }, "maintenance": false, "overwriteprotocol": "https", "allow_local_remote_servers": "true", "loglevel": 2, "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory", "theme": "", "memories.exiftool": "\/var\/www\/cloud.domain.tld\/apps\/memories\/bin-ext\/exiftool-amd64-glibc", "memories.vod.path": "\/var\/www\/cloud.domain.tld\/apps\/memories\/bin-ext\/go-vod-amd64", "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg", "memories.vod.ffprobe": "\/usr\/bin\/ffprobe", "memories.vod.disable": false, "skeletondirectory": "\/var\/www\/skel", "default_language": "en", "default_locale": "en_US", "force_locale": "en_US", "updater.secret": "***REMOVED SENSITIVE VALUE***" } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
This would be the relevant information... {"reqId":"BtECHJ9PMNbUE0y96jnX","level":3,"time":"2024-01-16T21:57:48+00:00","remoteAddr":"192.168.1.75","user":"joe.user","app":"index","method":"POST","url":"/index.php/contactsmenu/contacts","message":"Parameter \"guestName\" for route \"core.GuestAvatar.getAvatar\" must match \"[^/]++\" (\"\" given) to generate a corresponding URL.","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","version":"28.0.1.1","exception":{"Exception":"Symfony\\Component\\Routing\\Exception\\InvalidParameterException","Message":"Parameter \"guestName\" for route \"core.GuestAvatar.getAvatar\" must match \"[^/]++\" (\"\" given) to generate a corresponding URL.","Code":0,"Trace":[{"file":"/var/www/cloud.domain.tld/3rdparty/symfony/routing/Generator/UrlGenerator.php","line":161,"function":"doGenerate","class":"Symfony\\Component\\Routing\\Generator\\UrlGenerator","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/Route/Router.php","line":372,"function":"generate","class":"Symfony\\Component\\Routing\\Generator\\UrlGenerator","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/Route/CachingRouter.php","line":65,"function":"generate","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/URLGenerator.php","line":103,"function":"generate","class":"OC\\Route\\CachingRouter","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/URLGenerator.php","line":115,"function":"linkToRoute","class":"OC\\URLGenerator","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/Contacts/ContactsMenu/ContactsStore.php","line":345,"function":"linkToRouteAbsolute","class":"OC\\URLGenerator","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/Contacts/ContactsMenu/ContactsStore.php","line":162,"function":"contactArrayToEntry","class":"OC\\Contacts\\ContactsMenu\\ContactsStore","type":"->"},{"function":"OC\\Contacts\\ContactsMenu\\{closure}","class":"OC\\Contacts\\ContactsMenu\\ContactsStore","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/cloud.domain.tld/lib/private/Contacts/ContactsMenu/ContactsStore.php","line":161,"function":"array_map"},{"file":"/var/www/cloud.domain.tld/lib/private/Contacts/ContactsMenu/Manager.php","line":54,"function":"getContacts","class":"OC\\Contacts\\ContactsMenu\\ContactsStore","type":"->"},{"file":"/var/www/cloud.domain.tld/core/Controller/ContactsMenuController.php","line":51,"function":"getEntries","class":"OC\\Contacts\\ContactsMenu\\Manager","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/AppFramework/Http/Dispatcher.php","line":230,"function":"index","class":"OC\\Core\\Controller\\ContactsMenuController","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/AppFramework/Http/Dispatcher.php","line":137,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/AppFramework/App.php","line":184,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/cloud.domain.tld/lib/private/Route/Router.php","line":315,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/cloud.domain.tld/lib/base.php","line":1069,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/cloud.domain.tld/index.php","line":39,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/cloud.domain.tld/3rdparty/symfony/routing/Generator/UrlGenerator.php","Line":194,"message":"Parameter \"guestName\" for route \"core.GuestAvatar.getAvatar\" must match \"[^/]++\" (\"\" given) to generate a corresponding URL.","exception":{},"CustomMessage":"Parameter \"guestName\" for route \"core.GuestAvatar.getAvatar\" must match \"[^/]++\" (\"\" given) to generate a corresponding URL."}}Additional info
No response
The text was updated successfully, but these errors were encountered: