Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔢 Implement server-side DAV pagination #45102

Open
sorbaugh opened this issue Apr 30, 2024 · 3 comments
Open

🔢 Implement server-side DAV pagination #45102

sorbaugh opened this issue Apr 30, 2024 · 3 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: dav performance 🚀 🍀 2025-Spring
Milestone

Comments

@sorbaugh
Copy link
Contributor

sorbaugh commented Apr 30, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Description

Currently, iOS is limited in execution time and data/memory consumption. There is very little available memory and a PROPFIND of a few hundred records is enough to cause an overflow. Therefore, not having pagination, every time a single item changes you have to reload the entire folder with an incalculable waste of time and resources.

Something like a limit to 50 files per query/run would be good.

There are 3 closed PRs that wanted to tackle this problem, we could think of a new approach or "revive" this one if it's more pragmatic.

https://github.com/sabre-io/dav/pull/1074/files

nextcloud/3rdparty#139

#10880

@sorbaugh sorbaugh added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 30, 2024
@sorbaugh sorbaugh added this to the Nextcloud 30 milestone Apr 30, 2024
@AndyScherzinger AndyScherzinger changed the title Implement server-side DAV pagination 🔢 Implement server-side DAV pagination May 1, 2024
@susnux
Copy link
Contributor

susnux commented Jul 31, 2024

@sorbaugh
Copy link
Contributor Author

sorbaugh commented Oct 7, 2024

Update:

@icewind1991 's PR on sabre/dav to handle pagination has been since merged: sabre-io/dav#1074

However we're still waiting for a release to be made on their side. After this is done, we have 2 things to do:

  1. Bump the sabre/dav version
  2. Revive the logic from this PR and merge it: A dav plugin to allow pagination of multipart responses #10880

IF no new release is made on sabre's side, the approach would be:

  1. Bump the sabre/dav version to have only minimal differences.
    1.1 Apply icewind's PR on the lib version we're using
  2. Revive the logic from this PR and merge it: A dav plugin to allow pagination of multipart responses #10880

cc @Altahrim

cc @tobiasKaminsky @marinofaggiana

@marinofaggiana
Copy link
Member

thanks, we wait confidently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: dav performance 🚀 🍀 2025-Spring
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

6 participants