Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation before deleting *any* quantity of items #47931

Open
BloodyIron opened this issue Sep 12, 2024 · 4 comments
Open

Ask for confirmation before deleting *any* quantity of items #47931

BloodyIron opened this issue Sep 12, 2024 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files feature: trashbin

Comments

@BloodyIron
Copy link

It's very easy to hit the Delete functions in the webGUI in the Files section without meaning it. I really don't want to have to restore files every single time I accidentally hit that button as that's time costly. I really would prefer we just have a dialogue of "Are you sure?" with Yes/No, or equivalent, pop up, every time, regardless of how many files are selected (singular, multiple, whatever).

Can we please have this added? This is how file handling workflows and UX works commonly across the majority of user GUIs that deal with file handling.

@BloodyIron BloodyIron added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Sep 12, 2024
@joshtrichards
Copy link
Member

We do: #46733 (upcoming v30) & #43231 (v29)

Also, some further refinement discussed here: #46732

@BloodyIron
Copy link
Author

No, I'm talking about even if the trashbin is enabled. I was told to create a new request in another thread. PLEASE RE OPEN THIS. Disabling the trashbin should not be required for this dialogue! The request is in ALL scenarios.

@joshtrichards
Copy link
Member

joshtrichards commented Sep 13, 2024

#43231 does not require the trashbin to be enabled. It does, however, require >5 items. I'll re-open this for eliminating the item requirement.

EDIT: Adjusted the title to make it clearer

@joshtrichards joshtrichards reopened this Sep 13, 2024
@joshtrichards joshtrichards changed the title Add "Are you sure?" Dialogue to every Files delete function in the webGUI Ask for confirmation before deleting *any* quantity of items Sep 13, 2024
@BloodyIron
Copy link
Author

#43231 does not require the trashbin to be enabled. It does, however, require >5 items. I'll re-open this for eliminating the item requirement.

EDIT: Adjusted the title to make it clearer

Indeed! Yes this is now in-line with what I had in mind, thanks for re-opening and whatnot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files feature: trashbin
Projects
None yet
Development

No branches or pull requests

2 participants