Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ConversationSettings) - add frontend support for enabling bots / webhooks #10059

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 27, 2023

☑️ Resolves

🖼️ Screenshots

🏡 After
image

Notes:

async updateBotsInformation(token) {
 ...
 response.data.ocs.data.concat([
     { id: 122, name: 'Dummy bot 1 ', description: 'It does nothing', state: 0 },
     { id: 123, name: 'Dummy bot 2 ', description: '  - This program is free software...', state: 2 },
   ]).forEach((bot) => {
 ...

🚧 Tasks

🏁 Checklist

src/services/botsService.js Outdated Show resolved Hide resolved
src/stores/bots.js Outdated Show resolved Hide resolved
src/stores/bots.js Outdated Show resolved Hide resolved
@Antreesy Antreesy changed the title [WIP] Feat/1879/webhooks frontend feat(ConversationSettings) - add frontend support for enabling bots / webhooks Jul 29, 2023
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice @Antreesy

I think we should use our switch component for this as opposed to the stateful buttons.

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 7, 2023

I think we should use our switch component for this as opposed to the stateful buttons.

You mean this one? Instead of NcButton only or the whole row, with a switch on the left side?
image

As was discussed with @jancborchardt, design was developed to align with appearance of apps list:
image

@nickvergessen
Copy link
Member

Backend is merged to master, please rebase :)

@nickvergessen
Copy link
Member

Rebased

@Antreesy Antreesy force-pushed the feat/1879/webhooks-frontend branch from 513e662 to 29e089f Compare August 7, 2023 14:37
@Antreesy Antreesy marked this pull request as ready for review August 7, 2023 14:38
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but tested only the settings page and enabling disabling installed call_summary_bot without testing the bot.

@Antreesy Antreesy merged commit 5e6a966 into master Aug 7, 2023
20 checks passed
@Antreesy Antreesy deleted the feat/1879/webhooks-frontend branch August 7, 2023 16:15
@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 7, 2023

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Frontend - Support displaying messages of "webhooks / bots / integrations"
4 participants