Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call view: minor improvements #1666

Open
DorraJaouad opened this issue May 21, 2024 · 6 comments
Open

Call view: minor improvements #1666

DorraJaouad opened this issue May 21, 2024 · 6 comments

Comments

@DorraJaouad
Copy link

Is your feature request related to a problem? Please describe.
In call view, I feel some information are missing and would be nice to have it.

Describe the solution you'd like
1/ The participants number is not there/ not visible.
2/ When someone is screensharing, I don't see who is that participant. It will be good to see their name at the bottom like in web
3/ The close screenshare button seems not aligned with the shape of the share stream (e.g: sharing a desktop screen , the rectangle is too far from the close button so they sometimes seem unrelated). If it is closer and aware of the shape or add a light frame to indicate that's an overlay, that will look better.

Describe alternatives you've considered
Mentioned above

@SystemKeeper
Copy link
Collaborator

Hey Dorra,

  1. are we talking iPad or iPhone here? For iPad it might be possible to add it to the top bar, I am failing to see where to put it on an iPhone 🧐
  2. nice idea, should be easily possible
  3. this might be tricky, because it depends on the size of the screensharing (and device orientation) and also if you zoomed the screenshare or not (you can double tap and also pinch to zoom there). We can experiment a bit, might be easier than I think.

@DorraJaouad
Copy link
Author

  1. iPhone, but indeed, the space is not enough, maybe not necessarily on top bar :3 ?
  2. If the size of screenshare can be known, is it possible to adjust the position of the button based on that ?

@SystemKeeper
Copy link
Collaborator

Regarding showing the participants name:

Any opinions @DorraJaouad @Ivansss ?

@SystemKeeper
Copy link
Collaborator

Just an idea. With a bit of styling, we could make the duration multiline and show the participant count there. (And yes, I was lazy and just used an emoji here)

@DorraJaouad
Copy link
Author

Or is it possible to add a footer and show number of participants and call time of each corner?
Also Google seems to use floating component to show num of participants

image

@Ivansss
Copy link
Member

Ivansss commented Jul 1, 2024

We were discussing about taking a similar approach last Friday :)
Move call time and participants number to chips (similar to the one in your screenshot or the one we use for showing the screensharing user) under the top bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants