Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make background white again #2403

Open
marcoambrosini opened this issue Nov 30, 2023 · 5 comments
Open

Make background white again #2403

marcoambrosini opened this issue Nov 30, 2023 · 5 comments

Comments

@marcoambrosini
Copy link
Member

marcoambrosini commented Nov 30, 2023

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

I think we should go back to a white background. Looks better and it's consistent with other nextcloud apps

Now:

Screenshot from 2023-11-30 05-49-23

Proposed change:

Screenshot from 2023-11-30 05-48-51

Describe alternatives you've considered

No response

Additional context

No response

cc @raimund-schluessler @jakobroehrl @nextcloud/designers

@raimund-schluessler
Copy link
Member

I think it looks better with the light gray background. It also gives a bit more contrast to the tasks.

@marcoambrosini
Copy link
Member Author

@raimund-schluessler I don't think that that contrast is needed. The page is easily readable without a gray background, and I think it doesn't make much sense that we have this in only this one app.
@nextcloud/designers ping again, what do you think?

@szaimen
Copy link
Contributor

szaimen commented Jan 2, 2024

I also think that white background is cleaner. What about making this configurable if we cannot agree on it?

@marcoambrosini
Copy link
Member Author

ping @jancborchardt @nimishavijay

@jancborchardt
Copy link
Member

jancborchardt commented Jul 1, 2024

I'd agree that the white background is better:

  • Looks more modern
  • Fits with the rest of the apps
  • The tasks are already well separated with their container lines

But of course it's your call as maintainer @raimund-schluessler :)

Just a configuration option would be overkill here. We just need a good default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants