Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-schema 2.3.0 is not working with workflow output #90

Open
maxulysse opened this issue Jan 21, 2025 · 5 comments
Open

nf-schema 2.3.0 is not working with workflow output #90

maxulysse opened this issue Jan 21, 2025 · 5 comments

Comments

@maxulysse
Copy link

Changing from 2.2.1 to 2.3.0 led to this error appearing while using the workflow output:

ERROR ~ Receiver class nextflow.validation.ValidationObserver does not define or inherit an implementation of the resolved method 'abstract void onWorkflowPublish(java.lang.Object)' of interface nextflow.trace.TraceObserver.
@nvnieuwk
Copy link
Collaborator

Adding void onWorkflowPublish(Object input) {} to the observer seems to fix this issue but that seems like an unnecessary extra step. @bentsherman could this be a Nextflow issue instead of an nf-schema issue?

@bentsherman
Copy link
Member

You need to build a new version of nf-schema against Nextflow 24.10 in order for the plugin to work with 24.10, because of this new trace observer event. It's not something we can automate unfortunately, we just need to find a better way to communicate breaking changes to the plugin interfaces.

I never thought of it as a breaking change before because we only added a new event, but I guess this breaks older plugin versions.

@nvnieuwk
Copy link
Collaborator

Thank you! It seems to work now that I added it to the observer file. Would you think it will be fine to keep the minimal nextflow version lower with that fix implemented? I'd like to support as many versions as possible

@bentsherman
Copy link
Member

You just need to release a new version that requires >=24.10, then Nextflow will use the newer version or the older version based on which version of Nextflow is being used

Really the older version should specify Nextflow >=23.10 AND <24.10, but the problem is that you can't know at which version after 23.10 that things will break 😅 We need some way to add it after the fact

@nvnieuwk
Copy link
Collaborator

Yes that sounds like a good idea! I'll simply bump the next version to be 24.10 or higher, most pipelines will use that one in the future anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants