Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The contributed pack folder is not deleted unistalling the plugin #243

Open
agiudiceandrea opened this issue Mar 21, 2023 · 2 comments
Open

Comments

@agiudiceandrea
Copy link
Contributor

The contributed pack files are installed by the plugin in the \profiles\[profie_name]\QuickMapServices\ folder.
When the plugin is uninstalled, such folder and the files inside it are not deleted.
I think it should be more correct that the plugin installed the contributed pack files under the plugin installation folder \profiles\[profie_name]\python\plugins\quick_map_services\ or that the plugin uninstallation procedure taked care of the deletion of the \profiles\[profie_name]\QuickMapServices\ folder and its content.

@simgislab simgislab added feedback needed Waiting for feedback from thread starter enhancement and removed feedback needed Waiting for feedback from thread starter labels Mar 21, 2023
@simgislab
Copy link
Member

It' a bit hard to remember now why we separated settings like that 5 years ago, but I agree that the plugin uninstallation should clean up after itself

@agiudiceandrea
Copy link
Contributor Author

@simgislab, thanks. Since the QuickMapServices folder stores a User folder with custom groups and services added by the user, alongside a Contributed with the groups and services from the contributed pack, then it would be fair to ask the user for confirmation when removing the QuickMapServices during the plugin uninstall procedure. Maybe it was also the reason to choose to have a separate folder outside the plugin folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants