Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about to change circle-map to C++ version? #66

Open
panxiaoguang opened this issue Jan 25, 2024 · 2 comments
Open

How about to change circle-map to C++ version? #66

panxiaoguang opened this issue Jan 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@panxiaoguang
Copy link

Description of feature

The original version of Circle-Map is a little bit slow, especially when it processes reads that contain a high percentage of ChrM. The C++ reimplementation of Circle-Map can deal with this situation and will be a faster alternative. Thus, It would be a good idea to use C++ version in the pipeline.
@panxiaoguang panxiaoguang added the enhancement New feature or request label Jan 25, 2024
@panxiaoguang
Copy link
Author

please find it in https://github.com/BGI-Qingdao/Circle-Map-cpp

@DSchreyer
Copy link
Collaborator

I agree. Can you try to make a pull request to dev for this ? I might be able to include it then into the newest version 1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panxiaoguang @DSchreyer