-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UniverSC to support other technologies #14
Comments
Hi, If you're still interested, would you be willing to add your tool as a module to nf-core/modules? Matthias |
Sorry for the late response, we've just had a holiday period here in Japan so I have been busy with family. I think that is a great idea. We are in the final stages of preparing a revised manuscript so I think the tool would be published soon. A nextflow module to accompany that would be ideal. Where do I start? |
Wow, Japan! Talk about a global network 😄 ! I see you already found your way on your own! |
Thank you, I've created a new branch here: https://github.com/TomKellyGenetics/nf-core-modules/tree/universc I'll submit a new PR to the modules repo when I have completed it. The template is very helpful. While we are still working towards publishing UniverSC, I have started a new position so my time is limited on top of family commitments. Sorry it may take time to get back to this but I am still interested in doing it. |
Great. Take your time, we can include it whenever it's ready. |
update: The module is passing unit tests and under review currently. nf-core/modules#1706 I'd expect it will be ready to integrate into pipelines (e.g., nf-core/demultiplex or nf-core/scrnaseq) in the near future. |
Update: the module running UniverSC v1.2.5.1 is stable so I think it is ready to proceed with developing a subworkflow to run it for scRNA-Seq as discussed with @apeltzer. I think similar code could used to run demultiplexing as well if it is beneficial to apply different implementations to each pipeline. |
This tool has now been merged into nf-core/modules and can be used as a drop-in replacement for Cell Ranger with exclusively open-source dependencies. It also supports a "technology" parameter to configure the run for data generated from other platforms or protocols, in addition to 10X Genomics Chromium. |
Is there a reason that "cellranger" (#7) is no longer available? I noticed it is no longer documented and has been removed (#28). As previously described, this is an open-source alternative with similar functionality which is currently under consideration for scRNA-Seq (nf-core/scrnaseq#185). If there are reasons I am not aware of for not including Cell Ranger in the current release, I will take these into consideration. If it is planned to add Cell Ranger or equivalent functionality after migrating to DSL2 I can support that. I am familiar with the Cell Ranger module (which supports the newer licensed version you used before) as well. |
Time 😛 We also haven't had anyone that wants to maintain, add it, or requested it since the v1.0.0. If you're volunteering, I'm happy to see it added! I think UniverSC sounds more appealing to me personally. I also thought scrnaseq ran the demux, but I took a look at the pipeline, and it looks like they don't? |
@emiller88 No we don't in scrnaseq - scdemux is currently handled by most people using cellranger mkfastq, in case that @TomKellyGenetics wants to add universc, I'd be more than happy to let that go and not add the cellranger mkfastq to this workflow.... |
Are the results from universc and cellranger the same? Is there any tradeoff between the two? We could also have both. |
Something I'm leaving for @TomKellyGenetics to answer, I have not performed a deep dive yet |
Thanks for clarifying @emiller88 that’s reassuring. It helps to understand the current state of the project and make sure no one else has plans for it. It is understandable that the change to DSL2 would be time-consuming and others were prioritised. I'm open to maintaining it after contributing but I would be doing it in my own time as I’ve changed jobs and have young kids. Please understand there may be responses at unusual times as I am based in an Asian timezone.
@apeltzer that may be possible. UniverSC was intended to offer similar functionality to This is because it is intended to run samples other than 10X Chromium (already supported by Cell Ranger |
Awesome! You won't be maintaining it alone, I'm hoping we can keep this as a joint effort.
So it sounds like supporting both would make sense? Anyone running 10x Chromium would want I'm just afraid if we only have UniverSC, then there will be plenty of people who want Cellranger. |
Fantastic, a community effort would be ideal in my view. This is something I'll gladly support depending on my availability.
That's understandable, they have equivalent functionality for different data. The API is very similar by design (so any one familiar with Cell Ranger should be able to use our open-source tools. If we have a subworkflow working for Cell Ranger or UniverSC, it is not much trouble to migrate a copy of it to the other one. This is exactly what we've done for This is less important to port to UniverSC as For the above reasons, I'd suggest to start by implementing |
We've recently released an open-source tool to expand the functionality of Cell Ranger to apply to other technologies. We provide a Docker container on an open-source license (see #2) which can be used to run Cell Ranger on other technologies without violating the 10X Genomics EULA. Note that this only applies to scRNA-Seq techniques at this stage.
GitHub repo: https://github.com/minoda-lab/universc
Docker container: https://hub.docker.com/r/tomkellygenetics/universc
Manuscript: https://www.biorxiv.org/content/10.1101/2021.01.19.427209v1
I'm willing to prepare a PR to call UniverSC in place of Cell Ranger is there is interest in doing this.
The text was updated successfully, but these errors were encountered: