Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve samplesheet generation #272

Closed
grst opened this issue Oct 8, 2024 · 4 comments
Closed

Improve samplesheet generation #272

grst opened this issue Oct 8, 2024 · 4 comments
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@grst
Copy link
Member

grst commented Oct 8, 2024

Description of feature

It's great that the pipeline can generate samplesheets for downstream pipelines automatically.
I suggest the following improvements:

  • always generate all types of samplesheets. It's computationally cheap, it saves one pipeline parameter, and sometimes the data can be used for multiple pipelines (e.g. rnafusion + rnaseq)
  • allow to explicitly set the strandedness for rnaseq samplesheets. It's currently always 'auto', but I'd like to set it explicitly to reverse for Illumina libraries.

Something we could also discuss at some later point is to carry on information from the demux samplesheet to the generated samplesheets, e.g. additional columns from the [Data] section could be added to the generated samplesheets.

@apeltzer @atrigila @nschcolnicov

@grst grst added the enhancement Improvement for existing functionality label Oct 8, 2024
@grst
Copy link
Member Author

grst commented Oct 8, 2024

Another issue: the output paths are not correct.

They currently are:

s3://xxxxxxxxxxxxx-dev/demultiplex/241003_A01664_XXXXXXXXXXXXXXX/101_d_xxx_S1_L001/101_d_xxx_S1_L001_R1_001.fastq.gz

while it should be

s3://xxxxxxxxxxxxx-dev/demultiplex/241003_A01664_XXXXXXXXXXXXXXX/241003_A01664_XXXXXXXXXXXXXXX/101_d_xxx_S1_L001_R1_001.fastq.gz

The path until s3://xxxxxxxxxxxxx-dev/demultiplex/241003_A01664_XXXXXXXXXXXXXXX is the output folder specified by the user, so it's not taking into account the publishDir subdirectory.

@atrigila atrigila self-assigned this Oct 10, 2024
@grst grst reopened this Oct 25, 2024
@grst
Copy link
Member Author

grst commented Oct 25, 2024

I just tested this with the dev version, and it seems the output paths are still incorrect as described in this comment: #272 (comment)

@nschcolnicov
Copy link
Contributor

@grst Ok, I'll take a look

@nschcolnicov nschcolnicov mentioned this issue Oct 29, 2024
11 tasks
@nschcolnicov
Copy link
Contributor

PR merged, closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants