Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: pasta/align #3759

Open
4 tasks done
luisas opened this issue Aug 18, 2023 · 3 comments · May be fixed by #6095
Open
4 tasks done

new module: pasta/align #3759

luisas opened this issue Aug 18, 2023 · 3 comments · May be fixed by #6095
Assignees
Labels
new module Adding a new module

Comments

@luisas
Copy link
Contributor

luisas commented Aug 18, 2023

Is there an existing module for this?

  • I have searched for the existing module

Is there an open PR for this?

  • I have searched for existing PRs

Is there an open issue for this?

  • I have searched for existing issues

Are you going to work on this?

  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module
@luisas luisas added the new module Adding a new module label Aug 18, 2023
@lrauschning lrauschning self-assigned this Oct 16, 2023
@famosab
Copy link
Contributor

famosab commented Jul 8, 2024

@lrauschning Do you have a PR you could link?

@lrauschning
Copy link
Contributor

When I was looking into this, smirarab/pasta#67 (orig. smirarab/pasta#64, see also jeetsukumaran/DendroPy#169) meant that the PASTA conda package was broken, so I did not look into it more.
From a cursory look just now, that seems to be resolved, so the module should be mostly copy/paste from e.g. the MAGUS module. Should have the time to have a proper look sometime next week, if you'd be interested in the module.

@famosab
Copy link
Contributor

famosab commented Jul 9, 2024

I was mostly looking through old(er) Issues but had a look and found the approach quite interesting. Would be nice to test another aligner. So if you have the time to build the module I'd be interested.

@lrauschning lrauschning linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
Status: No status
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants