Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTX_TO_H5AD module cannot take ch_star_index #370

Open
wzheng0520 opened this issue Sep 20, 2024 · 2 comments
Open

MTX_TO_H5AD module cannot take ch_star_index #370

wzheng0520 opened this issue Sep 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@wzheng0520
Copy link

Description of the bug

Hi,

Thanks for upgrading this pipeline into newer version, I think here is a issue I meet after upgrading. I found it might cause by ch_star_index code is updated from ch_star_index = params.star_index ? file(params.star_index) : [] into ch_star_index = star_index ? [[id: star_index.baseName], star_index] : []. It causes the ch_star_index changed into linked list stared with star_index.baseName. However, in MTX_TO_H5AD module, their input still take path star_index.

From my understanding, path star_index cannot accept the new ch_star_index format and we might need to either change the input formate for star_index into acceptable way or we might can directly use star_index = params.star_index ? file(params.star_index, checkIfExists: true) : null as input for MTX_TO_H5AD.

like this:

MTX_CONVERSION (
        ch_mtx_matrices,
        ch_input,
        ch_txp2gene,
        star_index
    )

Command used and terminal output

Error executing process > 'NFCORE_SCRNASEQ:SCRNASEQ:MTX_CONVERSION:MTX_TO_H5AD (1)'

Caused by:
  Not a valid path value type: java.util.LinkedHashMap ([id:STARIndex])


Tip: you can try to figure out what's wrong by changing to the process work dir and showing the script file named `.command.sh`

Relevant files

No response

System information

No response

@wzheng0520 wzheng0520 added the bug Something isn't working label Sep 20, 2024
@grst
Copy link
Member

grst commented Oct 28, 2024

We are currently refactoring the matrix conversion code in #369. This should hopefully also fix the error you are encountering.

@wzheng0520
Copy link
Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants