Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call empty droplets #81

Closed
grst opened this issue Jan 1, 2022 · 6 comments · Fixed by #301
Closed

Call empty droplets #81

grst opened this issue Jan 1, 2022 · 6 comments · Fixed by #301
Assignees
Labels
enhancement New feature or request

Comments

@grst
Copy link
Member

grst commented Jan 1, 2022

Is your feature request related to a problem? Please describe

I think it could be nice to have a step to distinguish empty droplets from actual cells.

As far as I know, Alevin/Kallisto only perform cell calling based on "knee plots", while cellranger implements the emptyDrops algorithm. According to the emptyDrops paper the method clearly outperforms filtering based on knee plots.

Describe the solution you'd like

Implement a process downstream of the aligner subworkflows running the emptyDrops algorithm.

Describe alternatives you've considered

This kind of filtering could be left to downstream pipelines such as #scflow.
However, IMO, it would still make sense to have this as a default even when not using scflow for downstream analysis.

Additional context

STARsolo implements the emptydrops algorithm as of version 2.7.8a which can be activated using the --soloCellFilter EmptyDrops_CR option: https://github.com/alexdobin/STAR/blob/master/docs/STARsolo.md#emptydrop-like-filtering

I don't know if emptyDrops is still state-of-the-art of if there's something more advanced by now.

@grst grst added the enhancement New feature or request label Jan 1, 2022
@grst
Copy link
Member Author

grst commented Jan 26, 2022

See comments by Rob Patro on Slack:
https://nfcore.slack.com/archives/CHN5BV5DW/p1643209151035000

@apeltzer apeltzer added this to the 2.1.0 milestone Jun 8, 2022
@grst grst modified the milestones: 2.1.0, 2.2.0 Jul 28, 2022
@fmalmeida
Copy link
Contributor

Is this related to what's happening in PR #153 ?

@pinin4fjords
Copy link
Member

pinin4fjords commented Feb 2, 2023

Hi all- FYI there is an 'dropletutils-scripts' package in Bioconda that will provide a container to do this already.

The scripts themselves are here: https://github.com/ebi-gene-expression-group/dropletutils-scripts

Here's Nextflow process that uses it (admittedly DSL1). Just thought I'd point this out- might be a shortcut to a module.

@grst grst modified the milestones: 2.2.0, 2.3.0 Feb 21, 2023
@fmalmeida
Copy link
Contributor

I will re-start the PR that has been on work on that since it was too problematic.
And I will use the suggested: 'dropletutils-scripts' from bioconductor.

Using this, we were able to have it in a private copy of the pipeline. I can then work in bringing the script and the module to here.

@fmalmeida
Copy link
Contributor

I have a PoC running for the main aligners. Once I figure it out for cellrangerarc I will open a PR with the whole description of the changes for discussion.

@fmalmeida fmalmeida linked a pull request Feb 29, 2024 that will close this issue
@fmalmeida
Copy link
Contributor

PR merged
😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants