Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use to_legacy_anndata function from spatialdata_io instead of custom code #75

Closed
fasterius opened this issue Apr 4, 2024 · 2 comments · Fixed by #91
Closed

Use to_legacy_anndata function from spatialdata_io instead of custom code #75

fasterius opened this issue Apr 4, 2024 · 2 comments · Fixed by #91
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@fasterius
Copy link
Collaborator

Description of feature

We are currently using custom code as a work-around as a replacement for the to_legacy_anndata function from spatialdata_io, which did not exist when the work with SpatialData in this pipeline was initiated. This function is now merged in the SpatialData repo, but there is an issue with using it: scverse/spatialdata-io#134.

As soon as this (and other possible issues) is fixed we should adopt the existing function instead of the custom one we have now.

@fasterius fasterius added the enhancement Improvement for existing functionality label Apr 4, 2024
@LucaMarconato
Copy link

Hi, I just fixed the linked issue. If you try the new to_legacy_anndata() please let us know in case the function needs some adjustments. We placed it under the experimental submodule because, as we encourage new packages not to rely on the legacy AnnData representation, we also didn't try using it in real world analyses, just in the ones we tested when developing the function (scanpy and squidpy).

@cavenel
Copy link
Collaborator

cavenel commented Oct 11, 2024

Looks like it is working now, I opened a PR with the updated function from spatialdata-io here: #91
We can close this issue once the PR is merged (some docker version to fix first).

@fasterius fasterius linked a pull request Oct 25, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants