Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Runs failing due to (potential) bug in utils method for fetching repo releases #3264

Open
awgymer opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@awgymer
Copy link
Contributor

awgymer commented Oct 30, 2024

Description of the bug

The method nf_core.utils.get_repo_releases is failing tests when trying to check MultiQC branches contain main.

The root of this issue is that the API endpoint we hit returns at most 30 branches.
Branches are returned alphabetically and it seems that overnight MultiQC got new branches which have pushed main onto the second page, and we do not iterate paginated API results.

It is worth noting that the same method calls endpoints for releases and tags which may also be paginated (although with higher per-page limits) and it is unclear to me what the effects of not iterating paginated results would be downstream on that method.

Command used and terminal output

No response

System information

No response

@awgymer awgymer added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant