Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running prettier on new pipeline during pipelines create fails silently #3266

Open
awgymer opened this issue Oct 30, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@awgymer
Copy link
Contributor

awgymer commented Oct 30, 2024

Description of the bug

In solving #3262 I discovered that the actual error is not simply in pipelines lint but rather that the code is broken for pipelines create when creating a brand new repo but in that instance you get a different error which is silently swallowed (due in part to the textual interface hiding certain logging).

Running textual console to capture print statements and switching logging to print reveals that when initially creating a pipeline with the command, the pre-commit prettier command fails due not being inside a git repository. You can make it fail loud (in the same way as running pipelines lint) if you run nf-core pipelines create from inside a git repository (that doesn't have a .prettierignore).

Command used and terminal output

nf-core pipelines create

... Follow TUI to create an nf-core pipeline (includes prettier config)

<THE FOLLOWING IS FROM TEXTUAL CONSOLE DEBUGGING>

RUNNING PRETTIER

[14:31:22] PRINT                                                                                                                                                                                                          lint_utils.py:95
FAILED PRETTIER: STDOUT: An error has occurred: FatalError: git failed. Is it installed, and are you in a Git repository directory?

System information

No response

@awgymer awgymer added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant